Skip to content

[release-v1.18] fix: containersource template labels are correctly set on deployment (#8634)#1478

Closed
openshift-cherrypick-robot wants to merge 2 commits into
openshift-knative:release-v1.18from
openshift-cherrypick-robot:cherry-pick-1474-to-release-v1.18
Closed

[release-v1.18] fix: containersource template labels are correctly set on deployment (#8634)#1478
openshift-cherrypick-robot wants to merge 2 commits into
openshift-knative:release-v1.18from
openshift-cherrypick-robot:cherry-pick-1474-to-release-v1.18

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 29, 2025

This is an automated cherry-pick of #1474

/assign creydr

@Cali0707 @creydr
fix: containersource template labels are correctly set on deployment (k…
e935560 
…native#8634)

* fix: containersource deployment respects template labels

Signed-off-by: Calum Murray <cmurray@redhat.com>

* test: containersource deployment respects template labels

Signed-off-by: Calum Murray <cmurray@redhat.com>

* fix: containersource also propagates annotations to deployment

Signed-off-by: Calum Murray <cmurray@redhat.com>

* Fix linter issue

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2025
Merged
@openshift-ci openshift-ci Bot requested review from Cali0707 and creydr July 29, 2025 18:36
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 29, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/419-test-e2e e935560 link true /test 419-test-e2e
ci/prow/419-test-reconciler e935560 link true /test 419-test-reconciler
ci/prow/419-test-conformance e935560 link true /test 419-test-conformance
ci/prow/419-test-encryption-auth-e2e e935560 link true /test 419-test-encryption-auth-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@creydr
Copy link
Copy Markdown
Collaborator

creydr commented Jul 31, 2025

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jul 31, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Copy Markdown
Collaborator

creydr commented Jul 31, 2025

Duplicate of #1476

@creydr creydr marked this as a duplicate of #1476 Jul 31, 2025
@creydr creydr closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@creydr creydr Awaiting requested review from creydr

Assignees

@creydr creydr

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @creydr @Cali0707