[release-v1.16] fix: containersource template labels are correctly set on deployment (#8634)#1474
Conversation
…native#8634) * fix: containersource deployment respects template labels Signed-off-by: Calum Murray <cmurray@redhat.com> * test: containersource deployment respects template labels Signed-off-by: Calum Murray <cmurray@redhat.com> * fix: containersource also propagates annotations to deployment Signed-off-by: Calum Murray <cmurray@redhat.com> * Fix linter issue --------- Signed-off-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v1.15 |
|
@creydr: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-v1.17 |
|
@creydr: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-v1.18 |
|
@creydr: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test 419-test-e2e |
openshift-merge-bot
Bot
merged commit 31cb727
into
openshift-knative:release-v1.16
|
@creydr: new pull request created: #1477 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@creydr: new pull request could not be created: failed to create pull request against openshift-knative/eventing#release-v1.17 from head openshift-cherrypick-robot:cherry-pick-1474-to-release-v1.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift-knative:release-v1.17 and openshift-cherrypick-robot:cherry-pick-1474-to-release-v1.17"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@creydr: new pull request created: #1478 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Backport of knative#8634