Skip to content

[release-v1.18] fix: containersource template labels are correctly set on deployment (#8634)#1476

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.18from
Cali0707:backport-containersource-labels-1.18
Jul 31, 2025
Merged

[release-v1.18] fix: containersource template labels are correctly set on deployment (#8634)#1476
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.18from
Cali0707:backport-containersource-labels-1.18

Conversation

@Cali0707
Copy link
Copy Markdown
Member

Backport of knative#8634

  • fix: containersource deployment respects template labels
  • test: containersource deployment respects template labels
  • fix: containersource also propagates annotations to deployment
  • Fix linter issue

…native#8634)

* fix: containersource deployment respects template labels

Signed-off-by: Calum Murray <cmurray@redhat.com>

* test: containersource deployment respects template labels

Signed-off-by: Calum Murray <cmurray@redhat.com>

* fix: containersource also propagates annotations to deployment

Signed-off-by: Calum Murray <cmurray@redhat.com>

* Fix linter issue

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
@openshift-ci openshift-ci Bot requested review from lberk and matzew July 29, 2025 13:04
@Cali0707
Copy link
Copy Markdown
Member Author

/cc @creydr @matzew

@openshift-ci openshift-ci Bot requested a review from creydr July 29, 2025 13:04
@creydr
Copy link
Copy Markdown
Collaborator

creydr commented Jul 31, 2025

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 988f047 into openshift-knative:release-v1.18 Jul 31, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants