-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarkDuplicates Input specificity and input refactor. #8118
Open
johnoooh
wants to merge
13
commits into
nf-core:master
Choose a base branch
from
johnoooh:bugfix/prefix_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixed input specificity.
…odespaces and in singularity/docker, but not conda.
…o bugfix/prefix_fixes
SPPearce
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is another open PR to pipe the cram output straight from mark duplicates too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MarkDuplicates on an HPC with scratch enabled, the globbed *.bam copys both the input and output bam from scratch to the work directory. The output needed to be more specific. It is now ${prefix}.bam for the output so it now targets the output bam/cram instead of all files with the right file extension. For more details see the issue.
This should fix the issue for MarkDuplicates but be on the lookout for other modules where this occurs.
The second part of this may be more controversial but I found the bam/cram declaration to be a bit difficult to read. Prefix did not actually mean prefix here, it meant ${prefix}.bam. Because of this it required some logic later on to change this to cram. I cleared this up and hopefully made it easier to read.
PR checklist
Addresses ##7792, but more modules could have issues.
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda