new module starfusion build #8107
Open
+684
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmalmeida Ready Four-One review ;-) |
|
@atrigila Now I swear it works |
famosab
reviewed
Mar 27, 2025
|
Can you add some ontologies too please. |
famosab
requested changes
Apr 2, 2025
Comment on lines
+14
to
+24
| """ | ||
| input[0] = [ | ||
| [ id:'minigenome_fasta' ], | ||
| file("https://github.com/STAR-Fusion/STAR-Fusion-Tutorial/raw/master/minigenome.fa") | ||
| ] | ||
| input[1] = [ | ||
| [ id:'minigenome_gtf' ], | ||
| file("https://github.com/STAR-Fusion/STAR-Fusion-Tutorial/raw/master/minigenome.gtf") | ||
| ] | ||
|
|
||
| input [2] = file("https://github.com/STAR-Fusion/STAR-Fusion-Tutorial/raw/master/CTAT_HumanFusionLib.mini.dat.gz") |
There was a problem hiding this comment.
I only realized this now (sorry for not seeing this earlier).
All test data used within modules should be located in the nf-core test-datasets repository. You find more info here: https://github.com/nf-core/test-datasets/blob/modules/README.md
Can you please check for suitable over there in the modules branch and add the data if there is no suitable data available? I'll review your PR :)
There was a problem hiding this comment.
I have added the necessary data for the module, the PR is here
I have added the .fa and .gtf as well because the uploaded fusion library only contains that part of the genome.
17 tasks
This was referenced Apr 8, 2025
Co-authored-by: Famke Bäuerle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda