Skip to content

new module starfusion build #8107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 24, 2025
Merged

new module starfusion build #8107

merged 11 commits into from
Apr 24, 2025

Conversation

martings
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@martings martings requested a review from atrigila March 26, 2025 13:15
@martings martings marked this pull request as ready for review March 26, 2025 13:44
@martings martings requested review from fmalmeida and removed request for atrigila March 26, 2025 13:44
@martings
Copy link
Contributor Author

@fmalmeida Ready Four-One review ;-)

@martings martings requested a review from atrigila March 26, 2025 15:49
@martings
Copy link
Contributor Author

@atrigila Now I swear it works

famosab
famosab reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already - just some questions :)

@SPPearce
Copy link
Contributor

Can you add some ontologies too please.

@delfiterradas delfiterradas enabled auto-merge March 31, 2025 23:44
@delfiterradas delfiterradas requested a review from SPPearce April 1, 2025 13:54
@delfiterradas delfiterradas requested a review from famosab April 1, 2025 16:18
famosab
famosab requested changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good now. Just one more request for the test-data :)

@atrigila atrigila mentioned this pull request Apr 7, 2025
Merged
17 tasks
This was referenced Apr 8, 2025
Merged
Merged
@delfiterradas delfiterradas requested a review from famosab April 23, 2025 19:58
famosab
famosab approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

@delfiterradas delfiterradas added this pull request to the merge queue Apr 24, 2025
Merged via the queue into nf-core:master with commit ba2c969 Apr 24, 2025
27 checks passed
@atrigila atrigila mentioned this pull request May 5, 2025
Closed
famosab added a commit to famosab/modules that referenced this pull request Jun 3, 2025
@martings @delfiterradas
@famosab @atrigila
new module starfusion build (nf-core#8107)
78c13b7 
* Init module starfusion build

* update test

* Fix lint problems

* Update snap

* Correct starfusion_build module and test

* Update modules/nf-core/starfusion/build/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update inputs for starfusion_build module to nf-core test_data paths

---------

Co-authored-by: Delfina Terradas <[email protected]>
Co-authored-by: Delfina Terradas <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Anabella Trigila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delfiterradas delfiterradas delfiterradas left review comments

@famosab famosab famosab approved these changes

@fmalmeida fmalmeida Awaiting requested review from fmalmeida

@atrigila atrigila Awaiting requested review from atrigila

@SPPearce SPPearce Awaiting requested review from SPPearce

Assignees

@martings martings

@alanmmobbs93 alanmmobbs93

@sofiromano sofiromano

@delfiterradas delfiterradas

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@martings @SPPearce @famosab @delfiterradas @alanmmobbs93 @sofiromano @atrigila