Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ctatsplicing/prepgenomelib and ctatsplicing/startocancerintrons #8144

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

anoronh4
Copy link
Contributor

@anoronh4 anoronh4 commented Mar 26, 2025

PR checklist

Closes rnafusion#628

The reason I am only doing stub tests only is for practicality. The smallest reference i could get was about half a Gb, even when starting with the minigenome.fa and minigenome.gtf suggested by the tool's maintainers. I also considered adding starfusion/build so that i wouldn't have to store the reference on test-datasets, however this takes almost an hour to run on my system.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@anoronh4 anoronh4 marked this pull request as draft March 26, 2025 20:59
@anoronh4 anoronh4 changed the title add ctatsplicing/prepgenomelib add ctatsplicing/prepgenomelib and ctatsplicing/startocancerintrons Mar 31, 2025
@anoronh4 anoronh4 marked this pull request as ready for review April 3, 2025 21:43
@anoronh4 anoronh4 requested a review from atrigila April 4, 2025 17:22
Copy link
Contributor

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on migrating these modules to nf-core modules! Left a few suggestions for small details. I am also tagging the author of these local modules, @nvnieuwk , so that he can give a final look in case I am missing something. There is an open PR here: #8107 which is adding the STARFUSION process, which could come very useful to add the non-stub test.

Comment on lines +6 to +8
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://data.broadinstitute.org/Trinity/CTAT_SINGULARITY/CTAT-SPLICING/ctat_splicing.v0.0.2.simg' :
'docker.io/trinityctat/ctat_splicing:0.0.2' }"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason I couldn't add these modules to the nf-core/modules repository is because of the containers. These are third party containers so we don't really have any control over what happens with these... I think it would be worth it to either look into adding these modules to bioconda first or at least add these containers to the nf-core quay repo if bioconda isn't an option

Copy link
Contributor Author

@anoronh4 anoronh4 Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm guessing bioconda is an option because i see other ctat packages have recipes there. i have never done this before but am willing to give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate local CTATSPLICING_STARTOCANCERINTRONS to nf-core/modules
3 participants