-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ctatsplicing/prepgenomelib and ctatsplicing/startocancerintrons #8144
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on migrating these modules to nf-core modules! Left a few suggestions for small details. I am also tagging the author of these local modules, @nvnieuwk , so that he can give a final look in case I am missing something. There is an open PR here: #8107 which is adding the STARFUSION
process, which could come very useful to add the non-stub test.
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? | ||
'https://data.broadinstitute.org/Trinity/CTAT_SINGULARITY/CTAT-SPLICING/ctat_splicing.v0.0.2.simg' : | ||
'docker.io/trinityctat/ctat_splicing:0.0.2' }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason I couldn't add these modules to the nf-core/modules repository is because of the containers. These are third party containers so we don't really have any control over what happens with these... I think it would be worth it to either look into adding these modules to bioconda first or at least add these containers to the nf-core quay repo if bioconda isn't an option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm guessing bioconda is an option because i see other ctat packages have recipes there. i have never done this before but am willing to give it a shot.
PR checklist
Closes rnafusion#628
The reason I am only doing stub tests only is for practicality. The smallest reference i could get was about half a Gb, even when starting with the minigenome.fa and minigenome.gtf suggested by the tool's maintainers. I also considered adding starfusion/build so that i wouldn't have to store the reference on test-datasets, however this takes almost an hour to run on my system.
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda