Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore rbac with empty meta panic #39141

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

shaoting-huang
Copy link
Contributor

related: #38985

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/test sig/testing test/integration integration test labels Jan 10, 2025
@shaoting-huang shaoting-huang changed the title fix: fix restore rbac empty meta crash fix: restore rbac with empty meta panic Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (7d32603) to head (5a2e27d).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/metastore/kv/rootcoord/kv_catalog.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39141       +/-   ##
===========================================
+ Coverage   69.64%   81.14%   +11.50%     
===========================================
  Files         296     1395     +1099     
  Lines       26633   197280   +170647     
===========================================
+ Hits        18548   160079   +141531     
- Misses       8085    31574    +23489     
- Partials        0     5627     +5627     
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.64% <ø> (ø)
Go 83.07% <85.00%> (∅)
Files with missing lines Coverage Δ
internal/proxy/impl.go 83.86% <100.00%> (ø)
internal/metastore/kv/rootcoord/kv_catalog.go 80.81% <82.35%> (ø)

... and 1097 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 10, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3cd7403 into milvus-io:master Jan 13, 2025
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jan 13, 2025
cp from master
pr: #39141
related: #38985

Signed-off-by: shaoting-huang <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Jan 13, 2025
cp from master: #39141
related: #38985

Signed-off-by: shaoting-huang <[email protected]>
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
@shaoting-huang shaoting-huang deleted the restore_rbac_check branch February 24, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants