Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] restore rbac empty meta panic #39143

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

shaoting-huang
Copy link
Contributor

cp from master: #39141
related: #38985

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/S Denotes a PR that changes 10-29 lines. labels Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (95809ca) to head (4b7ca95).
Report is 8 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/metastore/kv/rootcoord/kv_catalog.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39143      +/-   ##
==========================================
+ Coverage   81.02%   81.06%   +0.03%     
==========================================
  Files        1389     1389              
  Lines      196343   196352       +9     
==========================================
+ Hits       159091   159170      +79     
+ Misses      31629    31580      -49     
+ Partials     5623     5602      -21     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.55% <ø> (+<0.01%) ⬆️
Go 83.02% <85.00%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/impl.go 83.86% <100.00%> (+<0.01%) ⬆️
internal/metastore/kv/rootcoord/kv_catalog.go 80.81% <82.35%> (ø)

... and 40 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 10, 2025
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 11, 2025
@mergify mergify bot removed the ci-passed label Jan 11, 2025
@shaoting-huang
Copy link
Contributor Author

rerun ut

Copy link
Contributor

Hello shaoting-huang, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

@shaoting-huang
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jan 13, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 13, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3059fae into milvus-io:2.5 Jan 13, 2025
19 of 20 checks passed
@shaoting-huang shaoting-huang changed the title fix: [2.5] fix restore rbac empty meta crash fix: [2.5] restore rbac empty meta panic Jan 13, 2025
@shaoting-huang shaoting-huang deleted the restore_rbac_check_2.5 branch February 24, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants