Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] restore rbac with empty meta panic #39142

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

cp from master: #39141
related: #38985

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/S Denotes a PR that changes 10-29 lines. labels Jan 10, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@shaoting-huang Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug ci-passed labels Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (782cd74) to head (41fc1af).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39142      +/-   ##
==========================================
- Coverage   80.43%   80.43%   -0.01%     
==========================================
  Files        1077     1077              
  Lines      169720   169723       +3     
==========================================
- Hits       136518   136513       -5     
- Misses      28713    28716       +3     
- Partials     4489     4494       +5     
Files with missing lines Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 82.20% <100.00%> (ø)
internal/proxy/impl.go 83.87% <100.00%> (+<0.01%) ⬆️

... and 36 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug sig/testing size/S Denotes a PR that changes 10-29 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants