Fix PiCT reported bugs + build enhancements (14)

[swoocn]

• Add Search Filter feature.
• Implement Seller Marker popup consistency and positioning.
• Add Online Shopping feature in Registration Screen + Pick list feature in Buyer Screen.
• Introduce Nigerian Yoruba language.
• Introduce Japanese language.
• Resolve deprecated i18n request configuration setup for internationalization on FE.
• Update to Send/ Extract Pi Access Token to/ from Authorization Header.
• Add Toggle Management system; admin feature.
• [DevOps] Mod CI/ CD files to prevent accidental dependency drift.
• Bump to v1.5.5.

[see commits]

This PR is subject to change if additional fixes + enhancements are introduced before approval.

[swoocn]

Hi @tate1650 - Could you please keep this PR open and refrain from merging until I give the word?
Thanks!

[swoocn]

Hello @tate1650 -
We're ready to proceed with the release of the changes. Could you please review and approve accordingly?

Please note that the Online Shopping feature is still a WIP, so we've implemented a toggle system to hide it until it is determined production' ready. To ensure everything is set up correctly, you will need to create a record in the new toggles DB collection with the toggle name "onlineShoppingFeature" as shown below ->

You can easily add this using the Swagger UI tool (once it's fixed) with the same admin credentials used for the Sanctioned Seller Reporting [see screenshot below]. Alternatively, you may add the record manually.

I'll be around if you need assistance. Thanks again!

[tate1650]

Lookin' good! Left a few suggestions, most of which are not blocking a merge. There are two I'd like to address before merging though:

1. Making sure anything online shopping-related is protected by a toggle-check on the BE. Unless the feature is in a somewhat stable state, in which case we can just aim to have that done before it goes to prod ("somewhat stable" meaning if someone like a mod is messing around and hits that endpoint then nothing in the app will break)
2. If y'all have any interest in pursuing the embedded-SellerItem schema, are you all comfortable with the seller_items collection being dropped later on staging? We'd probably need to make the change from reference --> embedding before the model goes to prod. (Note that this item is totally irrelevant if you'd like to keep using the referenced collection instead).

[swoocn]

Thanks for the feedback @tate1650 -
We will address the feedback and update the PR accordingly.
Please stay tuned. 👍

[DarinHajou]

Since I can’t submit a formal review, I'll just drop a comment here.

I noticed that seller_id is being queried in SellerItem, but I don’t see an index on it. Bringing it up since it was flagged earlier and could impact performance. Also, are the /item/* routes (like add/delete) behind a feature toggle such as onlineShoppingFeature? I didn’t spot a check in the controller, wondering if that’s handled elsewhere.

Otherwise, things are looking solid!

[swoocn]

Since I can’t submit a formal review, I'll just drop a comment here.

I noticed that seller_id is being queried in SellerItem, but I don’t see an index on it. Bringing it up since it was flagged earlier and could impact performance. Also, are the /item/* routes (like add/delete) behind a feature toggle such as onlineShoppingFeature? I didn’t spot a check in the controller, wondering if that’s handled elsewhere.

Otherwise, things are looking solid!

Hi @DarinHajou - please review the PR @ map-of-pi/map-of-pi-backend-react#254 which addresses Tate's feedback. Thx!

[swoocn]

Hello @tate1650 - PR has been updated per your feedback. Please review the changes accordingly. I will be standing by. Thanks again!

[tate1650]

Looks great! Left one tiny comment on error messages, and had a sudden lightbulb moment about toggle stuff. If you wanna merge this and address these two items in a follow up PR I'm fine with that. Lemme know what you'd prefer to do.

[swoocn]

I've addressed your latest PR comments - please feel free to take another look.
If everything looks good to you, I'll let you do the honors of merging. Otherwise, I'll await any additional feedback.
Once fully approved and merged, please let me know when the changes are deployed to Staging so our PM can begin testing.
Thanks again @tate1650!

[swoocn]

Hi @tate1650 - we'll be adding a quick FE change to this PR; please refrain from merging for the time being until I give the word. Thanks again!

[swoocn]

Hi @tate1650 - we'll be adding a quick FE change to this PR; please refrain from merging for the time being until I give the word. Thanks again!

Alright @tate1650, please go ahead and merge accordingly. Please let me know when deployed to Staging so our PM can test/ validate the changes. Thx!