Skip to content

Conversation

tate1650
Copy link
Collaborator

@tate1650 tate1650 commented Apr 8, 2025

Changes summary (in no particular order):

  • Add explicit MongoDB connection pool specification (for scaling reasons)
  • Add Russia to sanctioned regions
  • Adjust Seller indexes and seller-fetch query to make more optimal use of indexing and reduce DB load
  • Ensure unique names of file uploads
  • Fix errors in Swagger UI

@tate1650 tate1650 requested a review from swoocn April 9, 2025 04:56
@tate1650 tate1650 marked this pull request as ready for review April 9, 2025 04:57
@tate1650
Copy link
Collaborator Author

tate1650 commented Apr 9, 2025

Hey @swoocn, can you give this a review when you get the chance?

@swoocn
Copy link
Member

swoocn commented Apr 10, 2025

Hey @swoocn, can you give this a review when you get the chance?

Sure thing! Just a heads up - that there will be some merge/ compile-time conflicts as a result of the PR @ #46, especially due to the simplified changes with the SellerType enum. 🙃

@swoocn
Copy link
Member

swoocn commented Apr 10, 2025

Hi @tate1650 - Overall, your initial changes look good to me! Could you please make the necessary re-adjustments once PR #46 is merged? I will be standing by; thanks!

@tate1650
Copy link
Collaborator Author

Sure thing! Just a heads up - that there will be some merge/ compile-time conflicts as a result of the PR @ #46, especially due to the simplified changes with the SellerType enum. 🙃

All good, I was anticipating that 😅 and will take care of it

@tate1650
Copy link
Collaborator Author

@swoocn Merge conflicts resolved. Wanna take another look? Once this is merged I can deploy all the changes to staging.

Copy link
Member

@swoocn swoocn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tate1650!
Thanks for the adjustments. 😎👍

Go ahead and merge when you're ready and please keep me posted about staging deployment.

@tate1650 tate1650 merged commit 787b757 into map-of-pi:dev Apr 17, 2025
@tate1650 tate1650 deleted the sync-repos branch April 17, 2025 18:37
@tate1650 tate1650 restored the sync-repos branch April 17, 2025 18:41
@tate1650 tate1650 deleted the sync-repos branch April 17, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants