Address PR comments from PiCT (14) #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix N+1 query for resolving seller settings; add indexing to seller item.
swoocn
requested review from
zolcsi,
hollusam,
omotoshoayomikun,
amt-fredrick-amoako,
soleil00,
DarinHajou,
adisa39 and
Frankdevlopes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DarinHajou
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Looks great! Earlier concerns from the previous PR are addressed here.
-
seller_id in SellerItem is now indexed
-
Toggle middleware (onlineShoppingFeature) added to relevant routes
-
N+1 query in resolveSellerSettings replaced with efficient batch lookup
Solid update! Nothing else from my side.
|
Awesome, thanks @DarinHajou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include ->
See Docker PR for reference @ map-of-pi/map-of-pi-docker#46