This repository was archived by the owner on Nov 4, 2023. It is now read-only.
Uber PR #20
Merged
Uber PR #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2020
Closed
lydell
reviewed
Apr 4, 2020
lydell
reviewed
Apr 4, 2020
lydell
reviewed
Apr 4, 2020
|
Sorry, I pressed the "Update branch" button but it doesn’t seem to be working. I wanted GitHub Actions to appear here. |
|
So, you need this #22 |
disable "loopfunc" jshint's rule because of a bug in it jshint/jshint#3100
|
@lydell I also updated readme.md. Please review. |
|
@lydell Is anything missing in this PR? I mean, actions run and pass. |
|
Sorry, I haven’t had time to review. But it’s on my list. |
|
Truly awesome! 🏅 Sorry for being so slow to review. I’m merging this into the Feel free to make more improvements if you like! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Closes #17
Closes #18
Closes #19