Rewrite async API to use promises

[andy128k]

Related to item 2 in #12

[lydell]

Hi! Wow, I did not expect anyone to come and do this! Amazing!

I’m curious – what’s your motivation to dive into this shitty code base? Just for “fun”? Do you use source-map-resolve and miss the async API? How far would you like to take the refactor?

[andy128k]

Hi

I was bored. And then yarn showed me this:

warning babel-jest > @jest/transform > jest-haste-map > sane > micromatch > snapdragon > source-map-resolve > [email protected]: https://github.com/lydell/resolve-url#deprecated
warning babel-jest > @jest/transform > jest-haste-map > sane > micromatch > snapdragon > source-map-resolve > [email protected]: Please see https://github.com/lydell/urix#deprecated

...

I do not use source-map-resolve directly.

If you still have such tasks I can try to do them too.

[lydell]

If your goal is to get rid of those deprecation warnings, then you need to know:

• source-map-resolve 0.6.0 already got rid of the deprecated dependencies.
• You’d spend your time better trying to fix that dependency chain. For example, the latest version of micromatch does not even depend on snapdragon anymore.

[andy128k]

My goal was to entertain myself. I don't care about those warnings that much.

[lydell]

Ok!

Here are some ideas I’ve played around with:

• The test suite covers a lot of cases, but is horrible to work with. I’d like to structure the tests in a better way, and use Jest.
• Maybe we can get rid of the sync functions since we’ve got await these days.
• Nicer API, that works well with TypeScript. Maybe write the whole thing in TypeScript?
• ESLint instead of JSHint.
• Prettier.
• Fixing Incorrect path resolving on Windows with multiple disks #9. Windows support is super not thought through.
• etc.

[andy128k]

Preview of conversion to Jest: 515124f

Like this?

[andy128k]

If you plan to get rid of sync functions it is better to do this before conversion to Jest. :)

[lydell]

Yeah, something like that.

Let’s get rid of the sync functions then!

Also, if you want to go the TypeScript route that’s probably good to do before tests, too.

[lydell]

I think it would be easier to merge all your PRs into one giant update-all-the-things PR. What do you think?

[andy128k]

#20 All changes are there

[lydell]

Closing in favor of #20.