update dep, move to ESM and require 12.20

[jimmywarting]

would also think this breaking change would be a grate opportunity to convert to using promises also.

[lydell]

Something like this should be done on the next branch which already uses promises (and which I feel pretty bad about never having released).

I’m going to copy in a message I wrote once in a Discord channel, asking me about the source-map-resolve package:

While that package does have a lot of downloads, many of the downloads are due to really bad dependency chains of semi-deprecated stuff 😵

It does do the job and is fairly well tested, but as I said here: #9 (comment)

I really dislike this package, so don’t expect anything. Try to use a different dependency if you can.

I made this a long time ago, so it has some pretty weird stuff in it.

There’s a branch that uses promises here #20 that I never released and feel really bad about – the person who made that PR put down a lot of effort that has never been released 😢

I’ve tried to come back to this package many times, but I always end up doing nothing in frustration. Source maps are so underspecified so it’s super hard to know how things should work and what the module should really do, and requires a lot of research on how different browsers behave…

All in all, I’m always a bit sad when I’m reminded about that package. It might help you, but it might also serve better as inspiration for doing stuff yourself in a better way

What’s your motivation for doing this?

[jimmywarting]

What’s your motivation for doing this?

It's all really about getting at least one (or few) sub package (including dev dependencies) to switch to become a ESM only package, then the rest of the top dependencies must also use ESM if they want updates.
My end goal is to get the package I want to become a ESM package too, but they are not willing to do that yet
So I'm tackling this from behind 😛

All in all it is just to get it to become better Deno compatible

[lydell]

My end goal is to get the package I want to become a ESM package too, but they are not willing to do that yet

Out of curiosity, which package is that?

[jimmywarting]

Out of curiosity, which package is that?

https://www.npmjs.com/package/node-wifi
https://npmgraph.js.org/?q=node-wifi

[lydell]

Looking at the graph you linked to, node-wifi doesn’t even depend on source-map-resolve?

[jimmywarting]

check the dev dependencies switch

[lydell]

712 modules. Ambitious!

I think “all” you need to do to get rid of source-map-resolve is to upgrade from Jest 26 to Jest 27 in node-wifi. That would be time better spent. And you’ll get rid of more deprecated packages, like sane.

[jimmywarting]

sooo, what will it be? merging or deprecating this?

[lydell]

I deprecated it.