[CodeGen][NPM] Account inserted passes for -start/stop options #148111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 11, 2025
cdevadas
approved these changes
Jul 11, 2025
vikramRH
force-pushed
the
users/vikramRH/npm_pending/port_imp_def
branch
from
8f1711b to
6887d0a
Compare
vikramRH
force-pushed
the
users/vikramRH/npm_pending/insert_start_stop_opt
branch
2 times, most recently
from
1eef1b9 to
a9015f9
Compare
vikramRH
force-pushed
the
users/vikramRH/npm_pending/port_imp_def
branch
from
6887d0a to
72587b4
Compare
vikramRH
force-pushed
the
users/vikramRH/npm_pending/insert_start_stop_opt
branch
from
a9015f9 to
7f105c0
Compare
vikramRH
force-pushed
the
users/vikramRH/npm_pending/port_imp_def
branch
from
72587b4 to
e26cae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #138830
This partly solves the issue #138831 for -enable-new-pm.
#137290 will not have this problem, but this needs to be added this till we migrate to the new pass builder structure.
Even with this, there is no way to -start-after an inserted pass right now.
Co-authored-by : Oke, Akshat <[email protected]>