review comment

vikramRH · vikramRH · commit 1eef1b97c806 · 2025-07-14T11:39:47.000+05:30
diff --git a/llvm/include/llvm/Passes/CodeGenPassBuilder.h b/llvm/include/llvm/Passes/CodeGenPassBuilder.h
@@ -579,9 +579,9 @@ template <typename DerivedT, typename TargetMachineT> class CodeGenPassBuilder {
   void insertPass(InsertedPassT &&Pass) const {
     AfterCallbacks.emplace_back(
         [&](StringRef Name, MachineFunctionPassManager &MFPM) mutable {
-          if (Name == TargetPassT::name()) {
-            if (runBeforeAdding(InsertedPassT::name()))
-              MFPM.addPass(std::forward<InsertedPassT>(Pass));
+          if (Name == TargetPassT::name() &&
+              runBeforeAdding(InsertedPassT::name())) {
+            MFPM.addPass(std::forward<InsertedPassT>(Pass));
           }
         });
   }

Original file line number	Diff line number	Diff line change
`@@ -579,9 +579,9 @@ template <typename DerivedT, typename TargetMachineT> class CodeGenPassBuilder {`
`579`	`579`	`void insertPass(InsertedPassT &&Pass) const {`
`580`	`580`	`AfterCallbacks.emplace_back(`
`581`	`581`	`[&](StringRef Name, MachineFunctionPassManager &MFPM) mutable {`
`582`		`- if (Name == TargetPassT::name()) {`
`583`		`- if (runBeforeAdding(InsertedPassT::name()))`
`584`		`- MFPM.addPass(std::forward<InsertedPassT>(Pass));`
	`582`	`+ if (Name == TargetPassT::name() &&`
	`583`	`+ runBeforeAdding(InsertedPassT::name())) {`
	`584`	`+ MFPM.addPass(std::forward<InsertedPassT>(Pass));`
`585`	`585`	`}`
`586`	`586`	`});`
`587`	`587`	`}`