Skip to content

[Merged by Bors] - chore: classify porting notes about ext #17809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Contributor

@Vierkantor Vierkantor commented Oct 16, 2024

I checked all porting notes mentioning ext and either fixed them (see #17810), or classified them as

This PR should contain only modifications to comments.


Open in Gitpod

I checked all porting notes mentioning `ext` and either fixed them, or classified them as
 * #5229 if it's a new `@[ext]` lemma
 * #11041 if it's a regression in `ext`
 * #11182 if `@[ext]` had to be removed

This PR should contain only modifications to comments.
@Vierkantor Vierkantor added porting-notes Mathlib3 to Mathlib4 porting notes. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

PR summary c102b349b6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 16, 2024
I checked all porting notes mentioning `ext` and either fixed them (see #17810), or classified them as
 * #5229 if it's a new `@[ext]` lemma
 * #11041 if it's a regression in `ext`
 * #11182 if `@[ext]` had to be removed

This PR should contain only modifications to comments.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: classify porting notes about ext [Merged by Bors] - chore: classify porting notes about ext Oct 16, 2024
@mathlib-bors mathlib-bors bot closed this Oct 16, 2024
@mathlib-bors mathlib-bors bot deleted the classify-ext-porting-notes branch October 16, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants