Fix CI by removing <a> and <button> nesting as well as ignoring some working links
#789
Conversation
|
OK it looks like our CI has rules that says we can not nest an |
choldgraf
changed the title
a inside button element<a> and <button> nesting as well as ignoring some working links
| @@ -90,6 +90,8 @@ jobs: | |||
| --check-links-ignore "https://jupytercon.com" \ | |||
| --check-links-ignore "https://www.netapp.com" \ | |||
| --check-links-ignore "https://github.com/[^/]+/?$" \ | |||
| --check-links-ignore "https://sloan.org" \ | |||
| --check-links-ignore "https://www.bloomberg.com" \ | |||
There was a problem hiding this comment.
This one actually does not work for me. It redirects to https://bloomberg.com
There was a problem hiding this comment.
for me, going to "bloomberg.com" redirects to "www.bloomberg.com" 🤷
| cursor: pointer; | ||
| div.con-buttons { | ||
| margin-top: 2em; | ||
| a.con-button { |
There was a problem hiding this comment.
Is this acceptable support level https://caniuse.com/css-nesting - 87.4% of global users?
There was a problem hiding this comment.
Isn't this SCSS getting compiled to CSS by Jekyll in the actual HTML output?
There was a problem hiding this comment.
Thanks so much @choldgraf!
It would be great to fix lighthouse one day too, though it is annoying that it randomly starts failing after few months due to CI being CI.
|
thanks - I'll merge since this is an improvement over what's there. I opened this PR to see if there's an easy fix for lighthouse, let's see |
This fixes a failing CI due to a rule that we can't nest a button inside of an
aelement. It also adds two ignore rules for links that were returning errors even though they were valid (and these are common / stable links so I think it's safe to ignore them).