Skip to content

Add banner for JupyterCon 2025 #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Add banner for JupyterCon 2025 #788

merged 1 commit into from
Apr 9, 2025

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Apr 9, 2025

This adds a banner for JupyterCon 2025. It re-uses the background from the jupytercon.com banner and it basically re-adds the banner HTML/CSS that we removed in github.com//pull/729 . cc @rpwagner to do with this as he wishes!

Here's what the banner looks like on a 1080 pixel width screen

CleanShot 2025-04-08 at 20 10 07@2x

@rpwagner
Copy link
Contributor

rpwagner commented Apr 9, 2025

Yes! Thank you @choldgraf! This is more than good enough for me.

@rpwagner rpwagner self-requested a review April 9, 2025 06:28
Copy link
Contributor

@rpwagner rpwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a banner and the div tag and css looks reasonable.

@rpwagner rpwagner merged commit a19298a into main Apr 9, 2025
2 of 5 checks passed
@krassowski
Copy link
Member

It would be nice to make sure the tests pass.

@krassowski krassowski deleted the jcon-2025 branch April 9, 2025 08:59
@choldgraf
Copy link
Collaborator Author

It seemed like the two failing links were not related to this PR and also were valid links so I wasn't sure what to do about it. I don't understand the link checking infrastructure so I might be reading it wrong.

https://github.com/jupyter/jupyter.github.io/actions/runs/14348121869/job/40221705591#step:4:858

@krassowski
Copy link
Member

so I wasn't sure what to do about it

I would usually open an issue (like #762) and try to fix it later. Or one could count on volunteers who were keeping this CI up and clean to do that later.

But these were very much introduced by this PR:

"file:/github/workspace/_site/index.html":113.101-113.108: error: The element "button" must not appear as a descendant of the "a" element.
"file:/github/workspace/_site/index.html":114.113-114.120: error: The element "button" must not appear as a descendant of the "a" element.

@choldgraf
Copy link
Collaborator Author

Oh yeah - I was just looking at the link checks.

Sure I will open an issue if it is important that buttons are not descendants of links.

@choldgraf
Copy link
Collaborator Author

I've got a follow up PR here:

I also fixed the failing links.

Apparently our CI imposes a rule that we cannot nest <a> and <button> inside of each other in either order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants