Skip to content

Fix CI by removing <a> and <button> nesting as well as ignoring some working links #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Fix CI by removing <a> and <button> nesting as well as ignoring some working links #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb39d51
Nest a inside button
choldgraf Apr 9, 2025
71fcc98
Add ignore rules for link check
choldgraf Apr 9, 2025
f3e70b9
Removing the use of buttons entirely
choldgraf Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ jobs:
--check-links-ignore "https://jupytercon.com" \
--check-links-ignore "https://www.netapp.com" \
--check-links-ignore "https://github.com/[^/]+/?$" \
--check-links-ignore "https://sloan.org" \
--check-links-ignore "https://www.bloomberg.com" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one actually does not work for me. It redirects to https://bloomberg.com

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me, going to "bloomberg.com" redirects to "www.bloomberg.com" 🤷

--check-links-ignore "https://opensource.org/licenses/BSD-3-Clause"

lighthouse:
Expand Down
23 changes: 13 additions & 10 deletions assets/css/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,19 @@
max-width: 500px;
}

.con-button button {
background-color: #f37726;
color: white;
margin: 0 .5em;
padding: 1em;
border-radius: 5px;
border: none;
font-size: 1em;
font-weight: 600;
cursor: pointer;
div.con-buttons {
margin-top: 2em;
a.con-button {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this acceptable support level https://caniuse.com/css-nesting - 87.4% of global users?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this SCSS getting compiled to CSS by Jekyll in the actual HTML output?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right!

background-color: #f37726;
color: white;
font-size: 1em;
font-weight: 600;
margin: 0 .5em;
padding: 1em;
border-radius: 5px;
border: none;
cursor: pointer;
}
}


6 changes: 4 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,10 @@
<div class="con-program">
<p>San Diego, California</p>
</div>
<a class="con-button" href="https://events.linuxfoundation.org/jupytercon/"><button>Conference Website</button></a>
<a class="con-button" href="https://events.linuxfoundation.org/jupytercon/program/cfp/"><button>Call for Proposals</button></a>
<div class="con-buttons">
<a class="con-button" role="button" href="https://events.linuxfoundation.org/jupytercon/">Conference Website</a>
<a class="con-button" role="button" href="https://events.linuxfoundation.org/jupytercon/program/cfp/">Call for Proposals</a>
</div>
</div>
</div>
</div>
Expand Down
Loading