-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hash_with_views error #587
Conversation
Change-Id: I601e37de0b08f76e8a9ee74cdd3f5d9e2cefef05
Change-Id: I5d1fd49bce5f9d20d3e7bf8af2595d6dfb15168b
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
"next release" means SynapseAI v1.14? |
yes, we remove this parameter from api. |
Okay, so we should wait for 1.14 to be released before merging this PR right? |
no, we need it now for internal use.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see. Let's just add a comment to remove this check at some point (when 1.15 is released I think).
Co-authored-by: regisss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix for Falcon error from PR huggingface#587 * Reformatted
fix hash_with_views error
this api is no longer valid at next release