Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hash_with_views error #587

Merged
merged 3 commits into from
Dec 8, 2023
Merged

fix hash_with_views error #587

merged 3 commits into from
Dec 8, 2023

Conversation

bgoldberg-habana
Copy link
Collaborator

fix hash_with_views error
this api is no longer valid at next release

Change-Id: I601e37de0b08f76e8a9ee74cdd3f5d9e2cefef05
Change-Id: I5d1fd49bce5f9d20d3e7bf8af2595d6dfb15168b
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss
Copy link
Collaborator

regisss commented Dec 7, 2023

"next release" means SynapseAI v1.14?

@bgoldberg-habana
Copy link
Collaborator Author

"next release" means SynapseAI v1.14?

yes, we remove this parameter from api.

@regisss
Copy link
Collaborator

regisss commented Dec 7, 2023

"next release" means SynapseAI v1.14?

yes, we remove this parameter from api.

Okay, so we should wait for 1.14 to be released before merging this PR right?

@bgoldberg-habana
Copy link
Collaborator Author

"next release" means SynapseAI v1.14?

yes, we remove this parameter from api.

Okay, so we should wait for 1.14 to be released before merging this PR right?

no, we need it now for internal use..

Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see. Let's just add a comment to remove this check at some point (when 1.15 is released I think).

examples/text-generation/utils.py Show resolved Hide resolved
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit f6af3fe into main Dec 8, 2023
@regisss regisss deleted the fix_hash branch December 8, 2023 09:08
schoi-habana added a commit that referenced this pull request Dec 20, 2023
libinta pushed a commit that referenced this pull request Dec 21, 2023
* Fix for Falcon error from PR #587

* Reformatted
dsocek pushed a commit to dsocek/optimum-habana that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants