Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hash_with_views error #587

Merged
merged 3 commits into from
Dec 8, 2023
+10 −2
Merged

fix hash_with_views error #587

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8171484
fix hash_with_views error
bgoldberg-habana Dec 7, 2023
06397cf
make style
bgoldberg-habana Dec 7, 2023
32a712e
Update examples/text-generation/utils.py
bgoldberg-habana Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/text-generation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
model_on_meta,
write_checkpoints_json,
)
from optimum.habana.utils import check_habana_frameworks_min_version, check_optimum_habana_min_version, set_seed
from optimum.habana.utils import check_habana_frameworks_version, check_optimum_habana_min_version, set_seed


def override_print(enable):
Expand Down Expand Up @@ -132,7 +132,7 @@ def setup_model(args, model_dtype, model_kwargs, logger):
if args.use_hpu_graphs:
from habana_frameworks.torch.hpu import wrap_in_hpu_graph

if check_habana_frameworks_min_version("1.13.0"):
if check_habana_frameworks_version("1.13.0"):
if model.config.model_type == "falcon":
args.skip_hash_with_views = True
model = wrap_in_hpu_graph(model, hash_with_views=not args.skip_hash_with_views)
Expand Down
7 changes: 7 additions & 0 deletions optimum/habana/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,13 @@ def check_habana_frameworks_min_version(min_version):
return True


def check_habana_frameworks_version(req_version):
"""
Checks if the installed version of `habana_frameworks` is equal to `req_version`.
"""
return get_habana_frameworks_version() == version.parse(req_version)


def get_device_name():
"""
Returns the name of the current device: Gaudi or Gaudi2.
Expand Down