Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Falcon error from PR #587 #608

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix for Falcon error from PR #587 #608

merged 2 commits into from
Dec 21, 2023

Conversation

schoi-habana
Copy link
Collaborator

After the PR #587, Falcon inference fails with Synapse 1.13.0 because this comparison in here always returns False.

return get_habana_frameworks_version() == version.parse(req_version)

This is because get_habana_frameworks_version() returns 1.13.0.xxx whereas version.parse(req_version) is 1.13.0.
Thus this PR was created to compare the major and minor versions.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@libinta libinta added the run-test Run CI for PRs from external contributors label Dec 20, 2023
@schoi-habana schoi-habana marked this pull request as ready for review December 20, 2023 21:54
@libinta libinta merged commit cba7f00 into main Dec 21, 2023
14 checks passed
@regisss regisss deleted the dev/schoi/falcon_1.13 branch December 22, 2023 09:01
dsocek pushed a commit to dsocek/optimum-habana that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants