Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redacted nested secrets path value #6710

Merged

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Feb 5, 2025

What does this PR do?

Redact secrets within complex nested paths.

Why is it important?

some secrets are getting skipped within diagnostics bundles

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None

@michel-laterman michel-laterman added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Feb 5, 2025
@michel-laterman michel-laterman marked this pull request as ready for review February 6, 2025 20:49
@michel-laterman michel-laterman requested a review from a team as a code owner February 6, 2025 20:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michel-laterman michel-laterman force-pushed the redact-keyname-contains-secret branch from 9861489 to 04e80a1 Compare February 7, 2025 00:22
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty for taking care of my comment

@michel-laterman michel-laterman enabled auto-merge (squash) February 7, 2025 00:54
@michel-laterman michel-laterman merged commit 647b43b into elastic:main Feb 7, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)
jlind23 pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)

Co-authored-by: Michel Laterman <[email protected]>
jlind23 pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)

Co-authored-by: Michel Laterman <[email protected]>
@pierrehilbert pierrehilbert added backport-9.0 Automated backport to the 9.0 branch and removed backport-9.0 Automated backport to the 9.0 branch labels Feb 7, 2025
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)
michel-laterman added a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)

Co-authored-by: Michel Laterman <[email protected]>
jlind23 pushed a commit that referenced this pull request Feb 7, 2025
Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)

Co-authored-by: Michel Laterman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants