-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redacted nested secrets path value #6710
Redacted nested secrets path value #6710
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
9861489
to
04e80a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty for taking care of my comment
|
Redact secrets within complex nested paths. (cherry picked from commit 647b43b)
Redact secrets within complex nested paths. (cherry picked from commit 647b43b)
Redact secrets within complex nested paths. (cherry picked from commit 647b43b)
Redact secrets within complex nested paths. (cherry picked from commit 647b43b)
Redact secrets within complex nested paths. (cherry picked from commit 647b43b) Co-authored-by: Michel Laterman <[email protected]>
Redact secrets within complex nested paths. (cherry picked from commit 647b43b) Co-authored-by: Michel Laterman <[email protected]>
Redact secrets within complex nested paths. (cherry picked from commit 647b43b)
Redact secrets within complex nested paths. (cherry picked from commit 647b43b) Co-authored-by: Michel Laterman <[email protected]>
Redact secrets within complex nested paths. (cherry picked from commit 647b43b) Co-authored-by: Michel Laterman <[email protected]>
What does this PR do?
Redact secrets within complex nested paths.
Why is it important?
some secrets are getting skipped within diagnostics bundles
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolI have added an integration test or an E2E testDisruptive User Impact
None