Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #6710) Redacted nested secrets path value #6740

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

What does this PR do?

Redact secrets within complex nested paths.

Why is it important?

some secrets are getting skipped within diagnostics bundles

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None


This is an automatic backport of pull request #6710 done by Mergify.

Redact secrets within complex nested paths.

(cherry picked from commit 647b43b)
@mergify mergify bot added the backport label Feb 7, 2025
@mergify mergify bot requested a review from a team as a code owner February 7, 2025 03:13
@mergify mergify bot requested review from pkoutsovasilis and removed request for a team February 7, 2025 03:13
@mergify mergify bot requested a review from kaanyalti February 7, 2025 03:13
@github-actions github-actions bot added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Feb 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23
Copy link
Contributor

jlind23 commented Feb 7, 2025

buildkite test it

@jlind23 jlind23 enabled auto-merge (squash) February 7, 2025 06:38
@michel-laterman
Copy link
Contributor

buildkite test this

Copy link
Contributor Author

mergify bot commented Feb 10, 2025

This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏

1 similar comment
Copy link
Contributor Author

mergify bot commented Feb 17, 2025

This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏

@jlind23 jlind23 merged commit f91a739 into 8.x Feb 18, 2025
15 checks passed
@jlind23 jlind23 deleted the mergify/bp/8.x/pr-6710 branch February 18, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants