[browser][AOT] faster wasm-opt in CI tests #115624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
pavelsavara
force-pushed
the
WasmNativeDebugSymbols
branch
from
efa4890 to
5a5d5ee
Compare
pavelsavara
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes Wasm AOT builds by removing unconditional debug symbol generation, introducing a toggle for native debug symbols, and adjusting test target conditions for CI runs.
- Remove
-gflag for fasterwasm-optpasses - Add a new
WasmNativeDebugSymbolsproperty - Update test targets to set strip/debug symbols only in CI AOT scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/browser/build/BrowserWasmApp.targets | Removed unconditional -g include for debug flags |
| eng/testing/tests.wasm.targets | Added WasmNativeDebugSymbols to property list |
| eng/testing/tests.browser.targets | Condition CI AOT builds for WasmNativeStrip and debug symbols |
Comments suppressed due to low confidence (1)
src/mono/browser/build/BrowserWasmApp.targets:323
- The new
WasmNativeDebugSymbolsproperty is introduced but never used. The-gflag was removed without replacing it with a conditional include based onWasmNativeDebugSymbols. Consider re-adding<_EmccCommonFlags Include="-g" Condition="'$(WasmNativeDebugSymbols)' == 'true'" />to preserve debug-symbol toggling.
<_EmccCommonFlags Include="-g" Condition="'$(WasmNativeStrip)' == 'false'" />
akoeplinger
approved these changes
May 16, 2025
This was referenced May 20, 2025
|
did this change the state of the binaries we use for the microbenchmarks? |
it depends on what flags those binaries use. But assuming default WasmNativeStrip true and WasmNativeDebugSymbols false, it should have no impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't add
-gjust becauseWasmNativeStripis false, there isWasmNativeDebugSymbolstrue for that.This is for all native builds.
We also drop
-gfrom helix AOT test builds.Contributes to #89402