Skip to content

Commit b8a8930

Browse files
authored
[browser][AOT] faster wasm-opt in CI tests (#115624)
* more * more
1 parent 1b86204 commit b8a8930

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

eng/testing/tests.browser.targets

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@
1313

1414
<!--
1515
- For regular library tests, it will use the symbols file from the runtime pack.
16-
- for AOT library tests, we use WasmNativeStrip=false, so we already have symbols
16+
- for AOT library tests, we avoid WasmNativeDebugSymbols so that we don't run OOM on helix during wasm-opt
1717
-->
18-
<WasmNativeStrip Condition="'$(WasmNativeStrip)' == '' and '$(RunAOTCompilation)' == 'true'">false</WasmNativeStrip>
18+
<WasmNativeStrip Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(RunAOTCompilation)' == 'true'">true</WasmNativeStrip>
19+
<WasmNativeDebugSymbols Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(RunAOTCompilation)' == 'true'">false</WasmNativeDebugSymbols>
1920
<WasmEmitSymbolMap Condition="'$(WasmEmitSymbolMap)' == ''">true</WasmEmitSymbolMap>
2021

2122
<_WasmMainJSFileName Condition="'$(WasmMainJSPath)' != ''">$([System.IO.Path]::GetFileName('$(WasmMainJSPath)'))</_WasmMainJSFileName>

eng/testing/tests.wasm.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
<_WasmPropertyNames Include="WasmDedup" />
134134
<_WasmPropertyNames Include="WasmLinkIcalls" />
135135
<_WasmPropertyNames Include="WasmNativeStrip" />
136+
<_WasmPropertyNames Include="WasmNativeDebugSymbols" />
136137
<_WasmPropertyNames Include="_WasmDevel" />
137138
<_WasmPropertyNames Include="_WasmStrictVersionMatch" />
138139
<_WasmPropertyNames Include="WasmEmitSymbolMap" />

src/mono/browser/build/BrowserWasmApp.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,6 @@
321321

322322
<_EmccCommonFlags Include="$(_DefaultEmccFlags)" />
323323
<_EmccCommonFlags Include="$(EmccFlags)" />
324-
<_EmccCommonFlags Include="-g" Condition="'$(WasmNativeStrip)' == 'false'" />
325324
<_EmccCommonFlags Include="-v" Condition="'$(EmccVerbose)' != 'false'" />
326325
<_EmccCommonFlags Include="-s DISABLE_EXCEPTION_CATCHING=0" Condition="'$(WasmEnableExceptionHandling)' == 'false'" />
327326
<_EmccCommonFlags Include="-fwasm-exceptions" Condition="'$(WasmEnableExceptionHandling)' == 'true'" />

0 commit comments

Comments
 (0)