[browser] move -g back to _EmccCommonFlags #115770
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
There was a problem hiding this comment.
Pull Request Overview
This PR moves the "-g" debug flag from the _EmccCFlags group back to the _EmccCommonFlags group as a followup to a previous change.
- The debug flag "-g" is now added to _EmccCommonFlags with a condition based on WasmNativeDebugSymbols.
- The same flag is removed from _EmccCFlags to avoid redundant or conflicting settings.
Comments suppressed due to low confidence (2)
src/mono/browser/build/BrowserWasmApp.targets:352
- Removing '-g' from _EmccCFlags is intentional; please ensure that any build steps that expected the debug flag in this group are updated to reference _EmccCommonFlags.
<_EmccCFlags Include="-g" Condition="'$(WasmNativeDebugSymbols)' == 'true'" />
src/mono/browser/build/BrowserWasmApp.targets:325
- Moving '-g' to _EmccCommonFlags centralizes its application; please verify that debug symbols are applied as intended in all build stages that previously relied on _EmccCFlags.
<_EmccCommonFlags Include="-g" Condition="'$(WasmNativeDebugSymbols)' == 'true'" />
maraf
approved these changes
May 20, 2025
akoeplinger
approved these changes
May 20, 2025
Open
3 tasks
|
/ba-g CI timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #115624