fix(dimsim): bridge simulator sensors and commands to Zenoh - #4127
Draft
ruthwikdasyam wants to merge 1 commit into
Draft
fix(dimsim): bridge simulator sensors and commands to Zenoh#4127ruthwikdasyam wants to merge 1 commit into
ruthwikdasyam wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Fixes #4124.
Problem
DimSim speaks LCM, so Zenoh runs miss sensors and movement commands.
Solution
Relay simulator topics to Zenoh and commands back to LCM; preserve direct LCM behavior and fix log-pipe shutdown ordering.
How to Test
Open http://localhost:8090/, drive from the Keyboard Teleop window, and check camera/LiDAR in Rerun (enable
world/lidar).Pre-commit, 5 focused tests, and mypy passed. A real headless smoke test verified changing sensors and simulated movement over Zenoh.
AI assistance
Checklist