Skip to content

Make Mac tests required - #4125

Open
Dreamsorcerer wants to merge 1 commit into
mainfrom
Dreamsorcerer-patch-1
Open

Dreamsorcerer wants to merge 1 commit into
mainfrom
Dreamsorcerer-patch-1

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

Safe to merge: the change makes macOS self-hosted test failures block completion as intended.

What we checked:

  • Compared the baseline and changed workflow configurations with an injected macOS failure and found that matrix.experimental=true in the baseline allowed the macOS leg to conclude successfully, leaving self-hosted-tests and ci-complete passing. T-Rex
  • After the change, matrix.experimental=false caused the same macOS failure to cause macos_leg_conclusion, self_hosted_tests_conclusion, and ci_complete_conclusion to be failures. T-Rex
  • A blocker was noted: no GitHub-hosted/self-hosted runner or live PR workflow dispatch was available, so this remained a narrow executable workflow-configuration validation rather than a live GitHub Actions run. T-Rex

Summary

  • The macOS self-hosted test entry is now required. A simulated macOS test failure now causes both the self-hosted test check and the branch-protection completion check to fail.

Reviews (1) · Last reviewed commit: "Make Mac tests required"

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
- Coverage   78.89%   78.89%   -0.01%     
==========================================
  Files        1468     1468              
  Lines      138785   138785              
  Branches    11934    11934              
==========================================
- Hits       109500   109496       -4     
- Misses      25889    25891       +2     
- Partials     3396     3398       +2     
Components Coverage Δ
Tests 94.81% <ø> (-0.01%) ⬇️
Flag Coverage Δ
OS-ubuntu-24.04-arm 74.84% <ø> (ø)
OS-ubuntu-latest 75.54% <ø> (-0.01%) ⬇️
Py-3.10 75.31% <ø> (-0.01%) ⬇️
Py-3.11 75.52% <ø> (-0.01%) ⬇️
Py-3.12 75.52% <ø> (ø)
SelfHosted-Large 30.74% <ø> (ø)
SelfHosted-Linux 36.29% <ø> (-0.01%) ⬇️
SelfHosted-macOS 35.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/0.0.14 ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant