Notify on checkout err #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- note NotifierService.sendNotification() signature already declared 'url' param as optional, but this change fixes some of the implementations that didn't respect the optionality.
|
This can work if we're okay with there being no message on the notification. I'd also like to change the reason from |
laur89
force-pushed
the
notify-on-checkout-err
branch
from
c24025b to
697c3a6
Compare
|
Personally I'd be okay with no message.
Dunno, IMHO it states pretty accurately what's going on - something went haywire at purchase/checkout step. |
laur89
force-pushed
the
notify-on-checkout-err
branch
2 times, most recently
from
51ff055 to
9ea146b
Compare
laur89
force-pushed
the
notify-on-checkout-err
branch
from
9ea146b to
abe0c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this depends on #427