test notifiers also without a provided URL

claabs · Feb 6, 2025 · abe0c6b · abe0c6b
1 parent 1a50eaa
commit abe0c6b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/device-login.ts b/src/device-login.ts
@@ -145,7 +145,8 @@ export class DeviceLogin {
           pendingRedirects.set(reqId, this.onTestVisit(resolve, reject).bind(this));
         }),
       ),
-      await this.notify(NotificationReason.TEST, url),
+      await this.notify(NotificationReason.TEST_WITH_URL, url),
+      await this.notify(NotificationReason.TEST_WITHOUT_URL),
     ]);
     pendingRedirects.delete(reqId);
   }
@@ -175,10 +176,9 @@ export class DeviceLogin {
   private async notify(reason: NotificationReason, inUrl?: string): Promise<void> {
     let url: string | undefined;
     if (inUrl) {
+      url = inUrl;
       if (config.webPortalConfig?.localtunnel) {
         url = await getLocaltunnelUrl(inUrl);
-      } else {
-        url = inUrl;
       }
     }
     this.L.info({ reason, url }, 'Dispatching notification');

diff --git a/src/interfaces/notification-reason.ts b/src/interfaces/notification-reason.ts
@@ -2,6 +2,7 @@ export enum NotificationReason {
   LOGIN = 'LOGIN',
   PURCHASE = 'PURCHASE',
   CREATE_ACCOUNT = 'CREATE_ACCOUNT',
-  TEST = 'TEST',
+  TEST_WITH_URL = 'TEST_WITH_URL',
+  TEST_WITHOUT_URL = 'TEST_WITHOUT_URL',
   PURCHASE_ERROR = 'PURCHASE ERROR',
 }