test notifiers also without a provided URL

claabs · Feb 6, 2025 · 9ea146b · 9ea146b
1 parent 1a50eaa
commit 9ea146b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/src/device-login.ts b/src/device-login.ts
@@ -145,7 +145,8 @@ export class DeviceLogin {
           pendingRedirects.set(reqId, this.onTestVisit(resolve, reject).bind(this));
         }),
       ),
-      await this.notify(NotificationReason.TEST, url),
+      await this.notify(NotificationReason.TEST_WITH_URL, url),
+      await this.notify(NotificationReason.TEST_WITHOUT_URL),
     ]);
     pendingRedirects.delete(reqId);
   }
@@ -172,14 +173,9 @@ export class DeviceLogin {
     pendingRedirects.delete(reqId);
   }
 
-  private async notify(reason: NotificationReason, inUrl?: string): Promise<void> {
-    let url: string | undefined;
-    if (inUrl) {
-      if (config.webPortalConfig?.localtunnel) {
-        url = await getLocaltunnelUrl(inUrl);
-      } else {
-        url = inUrl;
-      }
+  private async notify(reason: NotificationReason, url?: string): Promise<void> {
+    if (url && config.webPortalConfig?.localtunnel) {
+      url = await getLocaltunnelUrl(url);
     }
     this.L.info({ reason, url }, 'Dispatching notification');
     await sendNotification(this.user, reason, url);

diff --git a/src/interfaces/notification-reason.ts b/src/interfaces/notification-reason.ts
@@ -2,6 +2,7 @@ export enum NotificationReason {
   LOGIN = 'LOGIN',
   PURCHASE = 'PURCHASE',
   CREATE_ACCOUNT = 'CREATE_ACCOUNT',
-  TEST = 'TEST',
+  TEST_WITH_URL = 'TEST_WITH_URL',
+  TEST_WITHOUT_URL = 'TEST_WITHOUT_URL',
   PURCHASE_ERROR = 'PURCHASE ERROR',
 }