Skip to content

[BUG] Using export instead of export type for CommonJS compat #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Feb 3, 2025

Description of changes

Closes #3661
Closes #3551

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Turns out that in CJS projects, the use of export type erases runtime info, which causes failure in user projects when importing our types

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

Copy link

github-actions bot commented Feb 3, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

tazarov commented Feb 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tazarov tazarov enabled auto-merge (squash) February 3, 2025 20:52
@tazarov tazarov merged commit 2ea3635 into main Feb 3, 2025
92 checks passed
@tazarov tazarov deleted the trayan-02-03-fix_using_export_instead_of_export_type_for_cjs_compat_in_js_client branch February 3, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants