-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: IncludeEnum not exported from TS package #3551
Comments
@simonsmith, have you tried this: chroma/clients/js/test/add.collections.test.ts Lines 42 to 45 in b028309
Note The above is from our tests and it works fine without using any compiler hacks |
@tazarov Yes. My issue is as highlighted above, where it isn't exported from the package correctly. In your test example it's being imported locally, which isn't quite the same: import { IncludeEnum } from "../src/types"; |
@simonsmith, so this doesn't work chroma/clients/js/src/index.ts Lines 15 to 16 in cfc330e
Is your project CJS or ESM so that I can debug this? |
Same error here. |
I'll try and create a reproducible example for you |
@simonsmith, @eliasbiondo, we found a problem with our exports using #3666 should address your issue. But while we release the JS client you can also refer to resolution here - #3661 (comment) |
@tazarov Thanks! |
What happened?
Using version
1.10.4
of thechromadb
packageYou cannot pass strings to
include
, so I try to useIncludeEnum
(which is undocumented)This works fine from the TS compiler perspective. It shows up correctly in my editor and when creating a build. But at runtime it seems the enum is not exported correctly
Currently I have to just ignore the TS errors like so:
What is the recommended approach here? Perhaps easier to just use a
type
?Thanks!
Versions
chromadb 0.6.2, installed using Python 3.13.1
version
1.10.4
of thechromadb
JS packageRelates to #1332
Relevant log output
The text was updated successfully, but these errors were encountered: