-
Notifications
You must be signed in to change notification settings - Fork 38
Update to generalized interface #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would not recommend removing the |
It'll stay, the comment was not updated. Old specifications such as GRM, LRMP will imply the particle type and |
748a5ca to
83eadd8
Compare
fb813bf to
bf148e8
Compare
|
Interface changes:
|
68800e8 to
b7f6ba4
Compare
053ae52 to
f01feea
Compare
This commit additionally reverts changes made to the bulk reaction interface made in 900bb46, since they are planned to be reworked.
9267610 to
dc516df
Compare
This commit unifies the column model builder so that a unified unit operation interface is exposed while internally unit operations can have both different or unified implementations. Makes input field `SPATIAL_METHOD` mandatory.
08e5157 to
0befc7e
Compare
|
Seems like the CI is triggered for commits changing files listed under |
c278d4e to
9a221b0
Compare
* all GRM LRMP LRM 1D and 2D units * rename fields to `PORE_DIFFUSION` and `SURFACE_DIFFUSION` * 2D units: rename `COL_DISPERSION` to `COL_DISPERSION_AXIAL` * replace `PARTICLE_TYPE` by transport model bools
2bf8e90 to
d9b1305
Compare
* all GRM LRMP LRM 1D and 2D units * rename fields to `PORE_DIFFUSION` and `SURFACE_DIFFUSION` * 2D units: rename `COL_DISPERSION` to `COL_DISPERSION_AXIAL` * replace `PARTICLE_TYPE` by transport model bools
double check and document interface changes
enable_dgflag, eigen will become a required dependencyPAR_BOUNDARY_ORDER->FV_BOUNDARY_ORDER, remove par suffix from particle cell/element spacing types, e.g.EQUIDISTANT_PARPARTICLE_TYPE. instead, we will have explicit bools for what effects are included in the particle model, i.e.has_film_diffusionhas_pore_diffusion,has_surface_diffusion, which default tofalse. add automatic check for impossible/unsupported combinations. if a field is set to false, the corresponding parameter, if provided, is ignored.UNIT_TYPE:[x] make modified newton the new default, see Change default forUSE_MODIFIED_NEWTONtotrue#478