Remove public APIs obsoleted in versions 5.7.0 to 5.13.0 #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunrd0
approved these changes
Jan 11, 2024
teo-tsirpanis
force-pushed
the
obsolete-remove
branch
from
11ee255 to
b919e63
Compare
shaunrd0
approved these changes
Jul 25, 2025
|
|
||
| namespace TileDB.CSharp; | ||
|
|
||
| [Obsolete(Obsoletions.FilestoreApiMessage, DiagnosticId = Obsoletions.ConfigIteratorDiagId, UrlFormat = Obsoletions.SharedUrlFormat)] | ||
| [Obsolete(Obsoletions.FilestoreApiMessage, DiagnosticId = Obsoletions.FilestoreApiDiagId, UrlFormat = Obsoletions.SharedUrlFormat)] |
There was a problem hiding this comment.
Should these be removed since 5.18 was released and 5.19 is next?
There was a problem hiding this comment.
Oh I got it confused, didn't remember that the obsoletion ID was wrong and we're not actually removing these now.
I'm OK with keeping these around in C# until Core removes the underlying C APIs (which should happen soon).
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| namespace TileDB.CSharp; | |||
|
|
|||
| [Obsolete(Obsoletions.FilestoreApiMessage, DiagnosticId = Obsoletions.FilestoreApiDiagId, UrlFormat = Obsoletions.SharedUrlFormat)] | |||
There was a problem hiding this comment.
Ditto for my other comment, should these be removed?
teo-tsirpanis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent with the obsoletion policy, this PR removes or makes internal the APIs obsoleted in version 5.7.0. The latest released version is 5.8.0 and a subsequent PR will bump it to 5.9.0.