Skip to content

Remove public APIs obsoleted in version 5.7.0 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove public APIs obsoleted in version 5.7.0 #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50029c3
Remove public APIs obsoleted under code TILEDB0012.
teo-tsirpanis Jan 8, 2024
cd3e046
Remove public APIs obsoleted under code TILEDB0013.
teo-tsirpanis Jan 8, 2024
a15eff5
Remove a no longer needed workaround.
teo-tsirpanis Jan 8, 2024
dc57bda
Add a file with package validation suppressions.
teo-tsirpanis Jan 8, 2024
23b7893
Mark the example project as non-packable.
teo-tsirpanis Jan 8, 2024
11ee255
Merge branch 'main' into obsolete-remove
teo-tsirpanis Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/TileDB.CSharp.Example/TileDB.CSharp.Example.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<RootNamespace>TileDB.CSharp.Examples</RootNamespace>
<TargetFrameworks>net5.0;net6.0;net7.0</TargetFrameworks>
<UseCurrentRuntimeIdentifier>true</UseCurrentRuntimeIdentifier>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 0 additions & 3 deletions sources/TileDB.CSharp/Array.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
using TileDB.CSharp.Marshalling;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ArrayHandle = TileDB.CSharp.Marshalling.SafeHandles.ArrayHandle;
using ArraySchemaHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaHandle;
using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;

namespace TileDB.CSharp;

Expand Down
4 changes: 0 additions & 4 deletions sources/TileDB.CSharp/ArraySchema.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
using System.Collections.Generic;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ArraySchemaHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaHandle;
using FilterListHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterListHandle;
using DomainHandle = TileDB.CSharp.Marshalling.SafeHandles.DomainHandle;
using AttributeHandle = TileDB.CSharp.Marshalling.SafeHandles.AttributeHandle;

namespace TileDB.CSharp;

Expand Down
1 change: 0 additions & 1 deletion sources/TileDB.CSharp/ArraySchemaEvolution.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ArraySchemaEvolutionHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaEvolutionHandle;

namespace TileDB.CSharp;

Expand Down
2 changes: 0 additions & 2 deletions sources/TileDB.CSharp/Attribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
using TileDB.Interop;
using TileDB.CSharp.Marshalling;
using TileDB.CSharp.Marshalling.SafeHandles;
using AttributeHandle = TileDB.CSharp.Marshalling.SafeHandles.AttributeHandle;
using FilterListHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterListHandle;

namespace TileDB.CSharp;

Expand Down
263 changes: 263 additions & 0 deletions sources/TileDB.CSharp/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,263 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.__sFILE</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.ArrayHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.ArraySchemaEvolutionHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.ArraySchemaHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.AttributeHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.ConfigHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.ConfigIteratorHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.ContextHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.DimensionHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.DomainHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.FilterHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.FilterListHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.GroupHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.LibC</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.MarshaledString</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.MarshaledStringOut</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.QueryConditionHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.QueryHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.SpanExtensions</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_array_schema_evolution_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_array_schema_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_array_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_attribute_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_config_iter_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_config_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_ctx_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_dimension_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_domain_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_filter_list_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_filter_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_group_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_query_condition_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_query_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.tiledb_vfs_t</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.Interop.VFSHandle</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:TileDB.CSharp.EnumUtil.DataTypeToType(TileDB.CSharp.DataType)</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:TileDB.CSharp.EnumUtil.TypeToDataType(System.Type)</Target>
<Left>lib/net5.0/TileDB.CSharp.dll</Left>
<Right>lib/net5.0/TileDB.CSharp.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
1 change: 0 additions & 1 deletion sources/TileDB.CSharp/Config.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using System.Text;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;

namespace TileDB.CSharp;

Expand Down
2 changes: 0 additions & 2 deletions sources/TileDB.CSharp/ConfigIterator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using System;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;
using ConfigIteratorHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigIteratorHandle;

namespace TileDB.CSharp;

Expand Down
2 changes: 0 additions & 2 deletions sources/TileDB.CSharp/Context.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
using System.Text;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ContextHandle = TileDB.CSharp.Marshalling.SafeHandles.ContextHandle;
using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;

namespace TileDB.CSharp;

Expand Down
2 changes: 0 additions & 2 deletions sources/TileDB.CSharp/Dimension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
using TileDB.CSharp.Marshalling;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using DimensionHandle = TileDB.CSharp.Marshalling.SafeHandles.DimensionHandle;
using FilterListHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterListHandle;

namespace TileDB.CSharp;

Expand Down
2 changes: 0 additions & 2 deletions sources/TileDB.CSharp/Domain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using System;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using DomainHandle = TileDB.CSharp.Marshalling.SafeHandles.DomainHandle;
using DimensionHandle = TileDB.CSharp.Marshalling.SafeHandles.DimensionHandle;

namespace TileDB.CSharp;

Expand Down
6 changes: 2 additions & 4 deletions sources/TileDB.CSharp/Enums.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,8 +1134,7 @@ public static VfsMode VfsModeFromStr(string str)
/// </summary>
/// <param name="t">The type to convert.</param>
/// <exception cref="NotSupportedException"><paramref name="t"/> is unsupported.</exception>
[Obsolete(Obsoletions.DataTypeTypeConversionsMessage, DiagnosticId = Obsoletions.DataTypeTypeConversionsDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
public static DataType TypeToDataType(Type t)
internal static DataType TypeToDataType(Type t)
{
if (t == typeof(int))
{
Expand Down Expand Up @@ -1192,8 +1191,7 @@ public static DataType TypeToDataType(Type t)
}
}

[Obsolete(Obsoletions.DataTypeTypeConversionsMessage, DiagnosticId = Obsoletions.DataTypeTypeConversionsDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
public static Type DataTypeToType(DataType datatype)
internal static Type DataTypeToType(DataType datatype)
{
switch (datatype)
{
Expand Down
1 change: 0 additions & 1 deletion sources/TileDB.CSharp/File.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System.ComponentModel;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ArraySchemaHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaHandle;

namespace TileDB.CSharp;

Expand Down
1 change: 0 additions & 1 deletion sources/TileDB.CSharp/Filter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System.Runtime.InteropServices;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using FilterHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterHandle;

namespace TileDB.CSharp;

Expand Down
2 changes: 0 additions & 2 deletions sources/TileDB.CSharp/FilterList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using System;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using FilterHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterHandle;
using FilterListHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterListHandle;

namespace TileDB.CSharp;

Expand Down
Loading