Remove public APIs obsoleted in versions 5.7.0 to 5.13.0 (#363)

* Remove public APIs obsoleted under code TILEDB0012.

* Remove public APIs obsoleted under code TILEDB0013.

* Remove a no longer needed workaround.

* Add a file with package validation suppressions.

* Mark the example project as non-packable.

* Remove public APIs obsoleted under code TILEDB0014.

* Remove public APIs obsoleted under code TILEDB0015.

* Fix typos.

* Obsolete `FileStoreUtil`.

* Update a test.

Author: teo-tsirpanis

docs/obsoletions.md

@@ -10,7 +10,7 @@ Following [the deprecation policy of TileDB Embedded][core-deprecation], obsolet
 |[`TILEDB0012`](#TILEDB0012) …[`TILEDB0013`](#TILEDB0013)|5.7.0|5.9.0|
 |[`TILEDB0014`](#TILEDB0014) …[`TILEDB0014`](#TILEDB0014)|5.8.0|5.10.0|
 |[`TILEDB0015`](#TILEDB0015) …[`TILEDB0015`](#TILEDB0015)|5.13.0|5.15.0|
-|[`TILEDB0015`](#TILEDB0016) …[`TILEDB0015`](#TILEDB0016)|5.17.0|5.19.0|
+|[`TILEDB0016`](#TILEDB0016) …[`TILEDB0016`](#TILEDB0016)|5.17.0|5.19.0|
 
 ## `TILEDB0001` - Enum value names that start with `TILEDB_` were replaced with C#-friendly names.
 

examples/TileDB.CSharp.Example/TileDB.CSharp.Example.csproj

@@ -6,6 +6,7 @@
     <RootNamespace>TileDB.CSharp.Examples</RootNamespace>
     <TargetFramework>net8.0</TargetFramework>
     <UseCurrentRuntimeIdentifier>true</UseCurrentRuntimeIdentifier>
+    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>

sources/TileDB.CSharp/Array.cs

@@ -5,9 +5,6 @@
 using TileDB.CSharp.Marshalling;
 using TileDB.CSharp.Marshalling.SafeHandles;
 using TileDB.Interop;
-using ArrayHandle = TileDB.CSharp.Marshalling.SafeHandles.ArrayHandle;
-using ArraySchemaHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaHandle;
-using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;
 
 namespace TileDB.CSharp;
 
@@ -457,7 +454,7 @@ public static void Vacuum(Context ctx, string uri, Config? config = null)
         {
             using var dim = domain.Dimension(i);
             var dimName = dim.Name();
-            var dimType = EnumUtil.DataTypeToType(dim.Type());
+            var dimType = EnumUtil.DataTypeToNumericType(dim.Type());
 
             switch (Type.GetTypeCode(dimType))
             {

sources/TileDB.CSharp/ArraySchema.cs

@@ -2,10 +2,6 @@
 using System.Collections.Generic;
 using TileDB.CSharp.Marshalling.SafeHandles;
 using TileDB.Interop;
-using ArraySchemaHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaHandle;
-using FilterListHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterListHandle;
-using DomainHandle = TileDB.CSharp.Marshalling.SafeHandles.DomainHandle;
-using AttributeHandle = TileDB.CSharp.Marshalling.SafeHandles.AttributeHandle;
 using TileDB.CSharp.Marshalling;
 
 namespace TileDB.CSharp;

sources/TileDB.CSharp/ArraySchemaEvolution.cs

@@ -1,7 +1,6 @@
 using System;
 using TileDB.CSharp.Marshalling.SafeHandles;
 using TileDB.Interop;
-using ArraySchemaEvolutionHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaEvolutionHandle;
 
 namespace TileDB.CSharp;
 

sources/TileDB.CSharp/Attribute.cs

@@ -5,8 +5,6 @@
 using TileDB.Interop;
 using TileDB.CSharp.Marshalling;
 using TileDB.CSharp.Marshalling.SafeHandles;
-using AttributeHandle = TileDB.CSharp.Marshalling.SafeHandles.AttributeHandle;
-using FilterListHandle = TileDB.CSharp.Marshalling.SafeHandles.FilterListHandle;
 
 namespace TileDB.CSharp;
 

sources/TileDB.CSharp/CompatibilitySuppressions.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
-<Suppressions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
   <Suppression>
     <DiagnosticId>PKV006</DiagnosticId>
     <Target>net5.0</Target>

sources/TileDB.CSharp/Config.cs

@@ -3,7 +3,6 @@
 using System.Collections.Generic;
 using TileDB.CSharp.Marshalling.SafeHandles;
 using TileDB.Interop;
-using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;
 
 namespace TileDB.CSharp;
 
@@ -174,15 +173,6 @@ public void SaveToFile(string filename)
         ErrorHandling.CheckLastError(&p_tiledb_error, status);
     }
 
-    /// <summary>
-    /// Gets a <see cref="ConfigIterator"/> that enumerates over all options whose parameter namess start with a given prefix.
-    /// </summary>
-    /// <param name="prefix">The parameters' name's prefix.</param>
-    public ConfigIterator Iterate(string prefix)
-    {
-        return new ConfigIterator(_handle, prefix);
-    }
-
     /// <summary>
     /// Checks if two <see cref="Config"/>s have the same content.
     /// </summary>
@@ -206,11 +196,7 @@ public IEnumerator<KeyValuePair<string, string>> GetEnumerator() =>
 
     private sealed class Enumerator(Config config, string prefix) : IEnumerator<KeyValuePair<string, string>>
     {
-#pragma warning disable TILEDB0015 // Type or member is obsolete
-        // We use ConfigIterator as an implementation detail.
-        // In the future, ConfigIterator will become internal and replace this class.
         private readonly ConfigIterator _iterator = new(config.Handle, prefix);
-#pragma warning restore TILEDB0015 // Type or member is obsolete
 
         private readonly string _prefix = prefix;
 
@@ -224,7 +210,7 @@ public bool MoveNext()
             {
                 return false;
             }
-            _current = _iterator.HereImpl();
+            _current = _iterator.Here();
             _iterator.Next();
             return true;
         }

sources/TileDB.CSharp/ConfigIterator.cs

@@ -2,17 +2,13 @@
 using System.Collections.Generic;
 using TileDB.CSharp.Marshalling.SafeHandles;
 using TileDB.Interop;
-using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;
-using ConfigIteratorHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigIteratorHandle;
 
 namespace TileDB.CSharp;
 
-[Obsolete(Obsoletions.ConfigIteratorMessage, DiagnosticId = Obsoletions.ConfigIteratorDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
-public sealed unsafe class ConfigIterator : IDisposable
+internal sealed unsafe class ConfigIterator : IDisposable
 {
     private readonly ConfigIteratorHandle _handle;
     private readonly ConfigHandle _hConfig;
-    private bool _disposed;
 
     internal ConfigIterator(ConfigHandle hConfig, string prefix)
     {
@@ -22,24 +18,11 @@ internal ConfigIterator(ConfigHandle hConfig, string prefix)
 
     public void Dispose()
     {
-        Dispose(true);
+        _handle.Dispose();
     }
 
-    private void Dispose(bool disposing)
-    {
-        if (_disposed) return;
-        if (disposing && (!_handle.IsInvalid))
-        {
-            _handle.Dispose();
-        }
-
-        _disposed = true;
-    }
-
-    internal ConfigIteratorHandle Handle => _handle;
-
     // Internal overload that returns KVP to avoid the Tuple allocation.
-    internal KeyValuePair<string, string> HereImpl()
+    internal KeyValuePair<string, string> Here()
     {
         tiledb_error_t* p_tiledb_error;
         sbyte* paramPtr;
@@ -57,12 +40,6 @@ internal KeyValuePair<string, string> HereImpl()
         return new KeyValuePair<string, string>(param, value);
     }
 
-    public Tuple<string, string> Here()
-    {
-        var here = HereImpl();
-        return new Tuple<string, string>(here.Key, here.Value);
-    }
-
     public void Next()
     {
         tiledb_error_t* p_tiledb_error;

sources/TileDB.CSharp/Context.cs

@@ -7,8 +7,6 @@
 using System.Text;
 using TileDB.CSharp.Marshalling.SafeHandles;
 using TileDB.Interop;
-using ContextHandle = TileDB.CSharp.Marshalling.SafeHandles.ContextHandle;
-using ConfigHandle = TileDB.CSharp.Marshalling.SafeHandles.ConfigHandle;
 
 namespace TileDB.CSharp;