-
Notifications
You must be signed in to change notification settings - Fork 0
Improved macOS support #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
+ Coverage 80.8% 81.6% +0.8%
- Complexity 135 163 +28
=========================================
Files 16 23 +7
Lines 568 827 +259
Branches 66 97 +31
=========================================
+ Hits 459 675 +216
- Misses 69 91 +22
- Partials 40 61 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…h Queue; File System Events)
…n FS event stream using the native macOS APIs
…sing the native APIs to the caller
…at fully implements the `java.nio.file.WatchService` interface
…/nio-file-watch-service
Improved macOS support: JNA
…t/nio-file-watch-service
…io-file-watch-service Improved macOS support: `java.nio.file` Watch Service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things I noticed.
…-support/file-moves
…mall-fixes Improved macOS support: Small fixes
…ile-moves Improved macOS support: Support for moving/renaming files
Overview
This is the main PR to address #4. Helper PRs:
java.nio.file
Watch Service #41Tasks
ITEM_RENAMED
flag), including tests (useFiles.move
)Enqueue collections of events instead of individual events inMoved: Enqueue collections of events instead of individual events inWatchKey
MacWatchKey
? #48Use an internal index to more accurately track renamesMoved: Use an internal index to more accurately track renames on macOS #49