Skip to content

Improved macOS support #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

Improved macOS support #39

wants to merge 51 commits into from

Conversation

sungshik
Copy link
Contributor

@sungshik sungshik commented Apr 21, 2025

Overview

This is the main PR to address #4. Helper PRs:

Tasks

  • Support for renames (ITEM_RENAMED flag), including tests (use Files.move)
  • Enqueue collections of events instead of individual events in WatchKey (comment). Proposal: Move to separate issue.
  • Use an internal index to more accurately track renames. Proposal: Move to separate issue.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 81.32296% with 48 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (ec14259) to head (e21382d).

Files with missing lines Patch % Lines
...a/engineering/swat/watch/impl/mac/MacWatchKey.java 80.6% 4 Missing and 8 partials ⚠️
...neering/swat/watch/impl/mac/NativeEventStream.java 86.6% 4 Missing and 8 partials ⚠️
.../engineering/swat/watch/impl/mac/MacWatchable.java 56.5% 8 Missing and 2 partials ⚠️
...ava/engineering/swat/watch/impl/jdk/JDKPoller.java 63.6% 6 Missing and 2 partials ⚠️
...gineering/swat/watch/impl/mac/MacWatchService.java 53.8% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              main     #39     +/-   ##
=========================================
- Coverage     80.8%   79.1%   -1.7%     
- Complexity     135     158     +23     
=========================================
  Files           16      23      +7     
  Lines          568     822    +254     
  Branches        66      95     +29     
=========================================
+ Hits           459     651    +192     
- Misses          69     108     +39     
- Partials        40      63     +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sungshik and others added 27 commits April 21, 2025 09:04
…n FS event stream using the native macOS APIs
…at fully implements the `java.nio.file.WatchService` interface
…io-file-watch-service

Improved macOS support: `java.nio.file` Watch Service
Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things I noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants