Improved macOS support: Support for moving/renaming files #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-macos-support-main #44 +/- ##
==============================================================
- Coverage 79.1% 0 -79.2%
==============================================================
Files 23 0 -23
Lines 822 0 -822
Branches 95 0 -95
==============================================================
- Hits 651 0 -651
+ Misses 108 0 -108
+ Partials 63 0 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-support/file-moves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for moving files.
Due to the limited information that macOS associates with each rename event (only the path/inode), it's a challenge to figure out if a rename event pertains to the source or the target of the move. There are at least two alternative designs: (a) maintain an internal index of the file tree; (b) check if a path exists when a rename event comes in. Alternative (a) is potentially more accurate, but getting the concurrency right requires special care and can get quite non-trivial. This PR implements alternative (b) because it's relatively simple. The feature PR (#39) contains a separate task to consider alternative (a).
Note: This PR ignores the issue of generating events for content items when directories are moved (#45). We need to come up with a general design/approach to deal with those, and then we can revisit the macOS-specific implementation as well.