Skip to content

Improved macOS support: Small fixes #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sungshik
Copy link
Contributor

@sungshik sungshik commented May 2, 2025

This PR contains a number of small fixes to address the comments after commit e21382d in #39. See the commit messages for an overview.

@sungshik sungshik changed the base branch from main to improved-macos-support-main May 2, 2025 11:39
@sungshik sungshik mentioned this pull request May 2, 2025
3 tasks
@sungshik sungshik force-pushed the improved-macos-support/small-fixes branch from ca4229f to 2c08675 Compare May 2, 2025 12:15
@sungshik sungshik force-pushed the improved-macos-support/small-fixes branch from 3888661 to ec40ead Compare May 2, 2025 12:27
@sungshik sungshik changed the title Improved macos support/small fixes Improved macOS support: Small fixes May 2, 2025
@sungshik sungshik requested a review from DavyLandman May 2, 2025 13:33
@sungshik sungshik marked this pull request as ready for review May 2, 2025 13:33
Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small thing

@sungshik sungshik merged commit 4e3f180 into improved-macos-support-main May 2, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants