[19.0][MIG] base_user_role: Migration to 19.0 #382

tishmen · 2025-10-09T13:15:03Z

Scope

base_user_role only

Summary

Migrate to Odoo 19.0 following OCA guide.
API updates: group_ids rename, SUPERUSER_ID import from odoo.api.
Switch to models.Constraint and models.Index APIs.
Switch to res.groups privilege_id (drop category_id).
Replace trans_implied_ids usages with all_implied_ids where effective groups are expected.
Adjust search/tree view xpaths and <search><group> schema for 19.0.
Refactor default roles due to removal of default user in Odoo.

Pre-commit

Verified locally; auto-fixes applied and committed.

Tests

Command:

./odoo/odoo-bin -c odoo.conf -d bur19_tests_bur -i base_user_role --test-enable --test-tags "/base_user_role" --without-demo=all --log-level=info --stop-after-init

Result: green locally.

…608) * [ADD] New module 'base_user_role' * [FIX] base_user_role - Review * [FIX] base_user_role - Review s/is_active/is_enabled/ * [FIX] base_user_role - Review s/is_active/is_enabled/ * [IMP] base_user_role - Translations updated (template + FR) * [FIX] base_user_role - Lint

…le.line

…e view

* FIX: Update users' groups when a role is deleted * IMP: add some test cases to check user's groups when its last role line is removed * FIX: ensure that the user's groups are updated when its last role line is removed

…w api

Currently translated at 100,0% (37 of 37 strings) Translation: server-backend-11.0/server-backend-11.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-11-0/server-backend-11-0-base_user_role/da/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

the groups that have changed with respecto the role.

…notebook users line (#1170)

…users.role.line" This reverts commit b537941d5a2d1fcb3fbacc602124c1b3f6e1d495.

tishmen · 2025-10-09T13:27:40Z

Base migration PR for the role stack. Two downstream PRs depend on this PR via a temporary test requirement, following OCA guidance:

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

Dependent PRs

[19.0][MIG] base_user_role_company: Migration to 19.0 #383 base_user_role_company
[19.0][MIG] base_user_role_history: Migration to 19.0 #384 base_user_role_history

Notes

The dependents include a commit titled "[DON'T MERGE] test-requirements.txt"; we will drop that commit once this base PR is merged.
Local tests are green. Command used:

./odoo/odoo-bin -c odoo.conf -d bur19_tests_bur -i base_user_role --test-enable --test-tags "/base_user_role" --without-demo=all --log-level=info --stop-after-init

Maintainers ping

@sebalix @jcdrubay @novawish — thanks in advance for an initial look. This PR is kept as draft; happy to mark ready once you prefer.

rousseldenis · 2025-10-11T11:19:22Z

/ocabot migration base_user_role

rousseldenis · 2025-10-11T11:27:23Z

@tishmen Is this ready ? Some of commits can be squashed in migration one. If there are improvements, they can stay but making module name appear in commit message. Thanks

tishmen · 2025-10-11T14:49:37Z

@rousseldenis From my side this is ready for another look; The module is installing and checks/tests are passing.
I’ll squash the migration-only changes into a single “[19.0] [MIG] …” commit and ping you once done.

FrancoMaxime

LGTM: code review.

I agree with @rousseldenis comment.

tishmen · 2025-10-15T18:01:55Z

@FrancoMaxime @rousseldenis The commits have been squashed as suggested, please check the last commit for the full diff. Thank you!

StefanRijnhart

Please rebase to include #375
Include the version bump in the actual migration commit (it now has its own, unconventional commit) and rename the actual migration commit to adhere to the pattern [19.0][MIG] <module>: Migration to 19.0.

base_user_role/models/user.py

base_user_role/tests/test_user_role.py

StefanRijnhart

Thanks!

OCA-git-bot · 2025-11-10T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sebalix and others added 30 commits October 9, 2025 13:51

base_user_role: display roles as first tab in user form

ba7fa35

base_user_role - Set a default category to associated groups

129bc39

[MIG] base_user_role: Port to 10.0

dbdb3de

[FIX] Crash in base_user_role when role_id is not set on res.users.ro…

e9f3411

…le.line

[10.0][FIX] User group not updating when removing a user from the rol…

5dca1be

…e view

[MIG] base_user_role: Migration to 11.0

8c22198

[FIX+IMP] base_user_role: Several things:

10e48fd

* FIX: Update users' groups when a role is deleted * IMP: add some test cases to check user's groups when its last role line is removed * FIX: ensure that the user's groups are updated when its last role line is removed

[MIG] Update test cases for testing (unlink role and role line) to ne…

1ff1116

…w api

[IMP] Use default user to define default roles to create for a new user

449ab8a

[UPD] Update base_user_role.pot

9c9e7a4

Translated using Weblate (Danish)

721ff9f

Currently translated at 100,0% (37 of 37 strings) Translation: server-backend-11.0/server-backend-11.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-11-0/server-backend-11-0-base_user_role/da/

[MIG] base_user_role: Migration to 12.0

3fb9ddb

[UPD] README.rst

033ca5e

[UPD] Update base_user_role.pot

c5b4f40

Update translation files

0708391

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] README.rst

785a2ba

[12.0][FIX] readme

e01a7c1

[UPD] README.rst

44fcb7d

[MIG] base_import_match: Migration to 12.0

4e88ea5

[base_user_role] improve performance by only adding/removing from a user

a91d402

the groups that have changed with respecto the role.

[UPD] README.rst

aed7811

[10.0][UPD] base_user_role: Disabled Administrator user selection in …

2034325

…notebook users line (#1170)

Switch AGPL to LGPL license

6a0c33b

Revert "[FIX] Crash in base_user_role when role_id is not set on res.…

40e98cb

…users.role.line" This reverts commit b537941d5a2d1fcb3fbacc602124c1b3f6e1d495.

Make user_id and role_id required in base_user_role_line

98f5c4a

[IMP] make base_user_role_line company dependent

a8e21d4

FIX check_company

8bae23e

[MIG] base_user_role: Migration to 13.0

0858fd3

[IMP] base_user_role: black, isort

f677daa

tishmen pushed a commit to tishmen/server-backend that referenced this pull request Oct 9, 2025

[DON'T MERGE] test-requirements.txt (temporary dependency to OCA#382)

3ef9b78

This was referenced Oct 9, 2025

[19.0][MIG] base_user_role_company: Migration to 19.0 #383

Open

[19.0][MIG] base_user_role_history: Migration to 19.0 #384

Open

tishmen marked this pull request as ready for review October 9, 2025 13:22

tishmen marked this pull request as draft October 9, 2025 13:24

rousseldenis added the migration label Oct 11, 2025

OCA-git-bot added this to the 19.0 milestone Oct 11, 2025

OCA-git-bot mentioned this pull request Oct 11, 2025

Migration to version 19.0 #379

Open

7 tasks

FrancoMaxime approved these changes Oct 14, 2025

View reviewed changes

tishmen force-pushed the 19.0-mig-base_user_role branch from 85eaf43 to 98cfee7 Compare October 15, 2025 17:56

tishmen marked this pull request as ready for review October 15, 2025 18:41

StefanRijnhart mentioned this pull request Oct 26, 2025

[19.0] base_user_role: migration to Odoo 19 (privileges, constraints, group_ids, view fixes) — request branch #378

Closed

StefanRijnhart requested changes Oct 26, 2025

View reviewed changes

base_user_role/models/user.py Outdated Show resolved Hide resolved

base_user_role/tests/test_user_role.py Outdated Show resolved Hide resolved

tishmen force-pushed the 19.0-mig-base_user_role branch from 77c6293 to a3ac908 Compare November 9, 2025 22:50

Milan Topuzov added 2 commits November 9, 2025 23:57

[19.0][MIG] base_user_role: Migration to 19.0

6c42808

[IMP] pre-commit auto-fixes

6ba1bf6

tishmen force-pushed the 19.0-mig-base_user_role branch 2 times, most recently from 5a03f11 to 390affc Compare November 9, 2025 23:03

Milan Topuzov added 2 commits November 10, 2025 00:03

[19.0][MIG] base_user_role: use fields.Command for x2many ops

105096b

[19.0][MIG] base_user_role: default roles via is_default

390affc

cyrilmanuel approved these changes Nov 10, 2025

View reviewed changes

StefanRijnhart approved these changes Nov 10, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[19.0][MIG] base_user_role: Migration to 19.0 #382

[19.0][MIG] base_user_role: Migration to 19.0 #382

Uh oh!

tishmen commented Oct 9, 2025 •

edited by StefanRijnhart

Loading

Uh oh!

tishmen commented Oct 9, 2025

Uh oh!

rousseldenis commented Oct 11, 2025

Uh oh!

rousseldenis commented Oct 11, 2025

Uh oh!

tishmen commented Oct 11, 2025

Uh oh!

FrancoMaxime left a comment

Uh oh!

tishmen commented Oct 15, 2025

Uh oh!

StefanRijnhart left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

StefanRijnhart left a comment

Uh oh!

OCA-git-bot commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

53 participants

Uh oh!

[19.0][MIG] base_user_role: Migration to 19.0 #382

Are you sure you want to change the base?

[19.0][MIG] base_user_role: Migration to 19.0 #382

Uh oh!

Conversation

tishmen commented Oct 9, 2025 • edited by StefanRijnhart Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tishmen commented Oct 9, 2025

Uh oh!

rousseldenis commented Oct 11, 2025

Uh oh!

rousseldenis commented Oct 11, 2025

Uh oh!

tishmen commented Oct 11, 2025

Uh oh!

FrancoMaxime left a comment

Choose a reason for hiding this comment

Uh oh!

tishmen commented Oct 15, 2025

Uh oh!

StefanRijnhart left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

53 participants

tishmen commented Oct 9, 2025 •

edited by StefanRijnhart

Loading

StefanRijnhart left a comment •

edited

Loading