[MIG] base_user_role: replace default-user hack with explicit 'is_default' flag on roles; set default role lines from that flag; expose in views; adapt tests

Author: Milan Topuzov

base_user_role/models/role.py

@@ -47,6 +47,10 @@ class ResUsersRole(models.Model):
         help="Privilege assigned to the associated group.",
         readonly=False,
     )
+    is_default = fields.Boolean(
+        string="Default on new users",
+        help=("When enabled, this role is assigned to newly created users by default."),
+    )
 
     @api.depends("line_ids.user_id")
     def _compute_user_ids(self):

base_user_role/models/user.py

@@ -31,23 +31,15 @@ def _compute_show_alert(self):
 
     @api.model
     def _default_role_lines(self):
-        template_user = self.env.ref(
-            "base.template_portal_user_id", raise_if_not_found=False
-        )
-        default_values = []
-        if template_user:
-            for role_line in template_user.with_context(
-                active_test=False
-            ).role_line_ids:
-                default_values.append(
-                    {
-                        "role_id": role_line.role_id.id,
-                        "date_from": role_line.date_from,
-                        "date_to": role_line.date_to,
-                        "is_enabled": role_line.is_enabled,
-                    }
-                )
-        return default_values
+        """Default role lines for a new user.
+
+        In Odoo 19, the former ``base.default_user`` template was removed in
+        favor of a default group. There is no default user anymore to copy
+        role lines from. Use a boolean on roles to mark the ones that should
+        apply to new users.
+        """
+        default_roles = self.env["res.users.role"].search([("is_default", "=", True)])
+        return [{"role_id": r.id} for r in default_roles]
 
     @api.depends("role_line_ids.role_id")
     def _compute_role_ids(self):

base_user_role/tests/test_user_role.py

@@ -201,14 +201,9 @@ def test_role_line_unlink(self):
         self.assertFalse(role2_groups <= self.user_id.group_ids)
 
     def test_default_user_roles(self):
-        self.default_user.write(
-            {
-                "role_line_ids": [
-                    fields.Command.create({"role_id": self.role1_id.id}),
-                    fields.Command.create({"role_id": self.role2_id.id}),
-                ]
-            }
-        )
+        # Mark roles as default on new users
+        self.role1_id.is_default = True
+        self.role2_id.is_default = True
         user = self.user_model.create(
             {"name": "USER TEST (DEFAULT ROLES)", "login": "user_test_default_roles"}
         )

base_user_role/views/role.xml

@@ -38,6 +38,7 @@
                     <group>
                         <field name="name" />
                         <field name="group_id" required="0" readonly="1" />
+                        <field name="is_default" />
                     </group>
                     <notebook>
                         <page string="Groups">
@@ -76,6 +77,7 @@
         <field name="arch" type="xml">
             <list>
                 <field name="name" />
+                <field name="is_default" />
                 <field name="user_ids" />
             </list>
         </field>
@@ -88,6 +90,11 @@
                 <field name="name" />
                 <field name="user_ids" />
                 <field name="implied_ids" />
+                <filter
+                    name="is_default"
+                    string="Default"
+                    domain="[('is_default', '=', True)]"
+                />
             </search>
         </field>
     </record>