Skip to content

[19.0][MIG] base_user_role_company: Migration to 19.0 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: 19.0
Choose a base branch
from
Open

[19.0][MIG] base_user_role_company: Migration to 19.0 #383

wants to merge 45 commits into from

Conversation

@tishmen
Copy link

@tishmen tishmen commented Oct 9, 2025

Scope

  • base_user_role_company only

Summary

  • Migrate to Odoo 19.0 following OCA guide.
  • Override parent unique constraint with company-aware one: UNIQUE(user_id, role_id, company_id).
  • Tests aligned with 19.0 (group_ids API).

Pre-commit

  • Verified locally; no additional changes applied beyond auto-fixes.

Temporary dependency

  • Added a temporary reference in root test-requirements.txt to install base_user_role from the PR ref, per OCA guidelines.

Tests

Command:

./odoo/odoo-bin -c odoo.conf -d bur19_tests_burco -i base_user_role,base_user_role_company --test-enable --test-tags "/base_user_role_company" --without-demo=all --log-level=info --stop-after-init

Result: green locally.

Depends on:

Chandresh-OSI and others added 30 commits October 9, 2025 13:51
@Chandresh-OSI
[ADD] base_user_role_company: add per company user roles
f71aa02
@oca-travis
[UPD] Update base_user_role_company.pot
0f4fa6f
@OCA-git-bot
[UPD] README.rst
26160c4
@OCA-git-bot
[ADD] icon.png
2a06acb
@kos94ok-3D
[FIX] base_user_role_company: wrong xpath
39cf102
@OCA-git-bot
base_user_role_company 14.0.1.1.0
59a2aef
Added translation using Weblate (Italian)
2cda704
@dreispt
[FIX] base_user_role_company: roles not properly applied on login
3d82404
Translated using Weblate (Italian)
3c48773 
Currently translated at 100.0% (11 of 11 strings)

Translation: server-backend-14.0/server-backend-14.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/it/
@dreispt
[FIX] base_user_role_company: wrong menus on re-login
967e0cf 
Issue found on logout / relogin.
The user groups were applied correctly, but the main menu showed apps
the user did not have access to.

This was related to the menu caching mechanisn, that was disabled here.
@dreispt
[FIX] base_user_role_company: fix tests
25bdd00
@oca-travis
[UPD] Update base_user_role_company.pot
8dc7338
@OCA-git-bot
base_user_role_company 14.0.2.0.0
c90652d
@oca-transbot
Update translation files
51633e4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-14.0/server-backend-14.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/
@OCA-git-bot
base_user_role_company 14.0.2.0.1
6fb6454
@francesco-ooops
Translated using Weblate (Italian)
b56fe59 
Currently translated at 90.9% (10 of 11 strings)

Translation: server-backend-14.0/server-backend-14.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/it/
@Urvisha-OSI
[IMP] base_user_role_company: pre-commit stuff
e1845cd
@Urvisha-OSI
[MIG] base_user_role_company: Migration to 16.0
1eef139
[UPD] Update base_user_role_company.pot
3d32780
@OCA-git-bot
[UPD] README.rst
fc4b270
@weblate
Update translation files
f22ea7b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-16.0/server-backend-16.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/
@Ivorra78
Added translation using Weblate (Spanish)
c855204
@Ivorra78
Translated using Weblate (Spanish)
f84e851 
Currently translated at 100.0% (8 of 8 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/es/
@pedrocs-exo
Added translation using Weblate (Portuguese)
093fa16
@pedrocs-exo
Translated using Weblate (Portuguese)
52669a0 
Currently translated at 100.0% (8 of 8 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/pt/
@etobella
[FIX] base_user_role_company: Pylint fix
10d9d10
@Ivorra78
Translated using Weblate (Spanish)
dd4d820 
Currently translated at 100.0% (8 of 8 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/es/
@mymage
Translated using Weblate (Italian)
1401920 
Currently translated at 100.0% (8 of 8 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/it/
@sebalix
base_user_role_company: allow same role in different companies
fb4e653
@rconjour
[IMP] base_user_role_company: black, isort, prettier
42c608c
rconjour and others added 14 commits October 9, 2025 13:51
@rconjour
[MIG] base_user_role_company: Migration to 17.0
81efd36
@jdidderen
[IMP/FIX] base_user_role_company - re-add logic around multi active cids
7ee8755
@pedrobaeza
[FIX] base_user_role_company: Line too long
0aa3648
@BertVGroenendael
[IMP] base_user_role_company: pre-commit stuff
99db720
@BertVGroenendael
[MIG] base_user_role_company: Migration to 18.0
9498e8a
[UPD] Update base_user_role_company.pot
b8a76f2
@OCA-git-bot
[BOT] post-merge updates
4d57927
@weblate
Update translation files
3ba95f0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-18.0/server-backend-18.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-18-0/server-backend-18-0-base_user_role_company/
@TomVermeerenDynapps
[FIX] base_user_role_company: Roles are filtered so none which exceed…
f8a6e53 
… date_to are used
@legalsylvain
[FIX] base_user_role_company: Do not auto install this module.
e736ae1 
the _company module is an extra module used in a multi company context (and only in some situation). It is totally useless in mono company. As 2 modules exists, it doesn't makes sense to make the second auto_installable
@OCA-git-bot
[BOT] post-merge updates
801811c
@OCA-git-bot
[BOT] post-merge updates
0c1d4a3
[MIG] base_user_role_company: Migration to 19.0 (bump version to 19.0…
fdcb3af 
….1.0.0)
[IMP] pre-commit auto-fixes
4556476
@tishmen tishmen marked this pull request as ready for review October 9, 2025 13:22
@tishmen tishmen marked this pull request as draft October 9, 2025 13:24
@tishmen
Copy link
Author

tishmen commented Oct 9, 2025

Depends on #382.

Temporary dependency

Highlights

  • Unique constraint overridden to UNIQUE (user_id, role_id, company_id).
  • Company‑aware role enablement honored via active_company_ids.
  • Local tests green. Command used:
./odoo/odoo-bin -c odoo.conf -d bur19_tests_burco -i base_user_role,base_user_role_company --test-enable --test-tags "/base_user_role_company" --without-demo=all --log-level=info --stop-after-init

Maintainers ping

Kept as draft until #382 is approved/merged; can flip to ready on request.

@tishmen tishmen mentioned this pull request Oct 9, 2025
Merged
@tishmen tishmen force-pushed the 19.0-mig-base_user_role_company branch from 62f4ded to 111c4aa Compare October 15, 2025 18:31
[MIG] base_user_role_company: migrate to 19.0
c688a95 
- Replace groups_id with group_ids in views/actions
- Bump version to 19.0.1.0.0; adjust manifests/assets
- Use env attributes and Domain expressions
- Adopt new Constraint/Index APIs where applicable

Functional changes
@tishmen tishmen force-pushed the 19.0-mig-base_user_role_company branch from 567e0c0 to c688a95 Compare October 15, 2025 18:38
@tishmen tishmen marked this pull request as ready for review October 15, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.