refactor: split tracer setup code in its own part #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 ApprovalWonderful, this rule succeeded.
🟢 Continuous IntegrationWonderful, this rule succeeded.
🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
jd
force-pushed
the
devs/jd/capture-logs/Ib4124ff3dc885e609bb51b96f263b4733d5bc143
branch
from
a9a8311 to
d2fd5ea
Compare
jd
force-pushed
the
devs/jd/capture-logs/I2de0216fc8a6ef4cca1f37d00e56e97a2552f2b6
branch
2 times, most recently
from
d800068 to
7c5c977
Compare
Base automatically changed from
devs/jd/capture-logs/Ib4124ff3dc885e609bb51b96f263b4733d5bc143
to
main
December 18, 2024 16:47
|
@jd this pull request is now in conflict 😩 |
jd
force-pushed
the
devs/jd/capture-logs/I2de0216fc8a6ef4cca1f37d00e56e97a2552f2b6
branch
from
7c5c977 to
429445c
Compare
jd
force-pushed
the
devs/jd/capture-logs/I2de0216fc8a6ef4cca1f37d00e56e97a2552f2b6
branch
4 times, most recently
from
716c460 to
145d8b0
Compare
This will allow to replace the MergifyTracer dynamically in tests for easier scenario testing. Change-Id: I2de0216fc8a6ef4cca1f37d00e56e97a2552f2b6
jd
force-pushed
the
devs/jd/capture-logs/I2de0216fc8a6ef4cca1f37d00e56e97a2552f2b6
branch
from
145d8b0 to
ed6a94b
Compare
Greesb
approved these changes
Dec 19, 2024
mergify
bot
deleted the
devs/jd/capture-logs/I2de0216fc8a6ef4cca1f37d00e56e97a2552f2b6
branch
DouglasBlackwood
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to replace the MergifyTracer dynamically in tests for
easier scenario testing.