Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set API URL globally #24

Merged
merged 1 commit into from
Dec 18, 2024
Merged

test: set API URL globally #24

merged 1 commit into from
Dec 18, 2024

Conversation

jd
Copy link
Member

@jd jd commented Dec 18, 2024 •
edited
Loading

No description provided.

@jd
Copy link
Member Author

jd commented Dec 18, 2024 •
edited
Loading

This pull request is part of a stack:

  1. test: set API URL globally (#24) 👈
  2. refactor: split tracer setup code in its own part (#25)

@jd jd mentioned this pull request Dec 18, 2024
Closed
@mergify Mergify
Copy link

mergify bot commented Dec 18, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@jd jd mentioned this pull request Dec 18, 2024
Merged
@jd
test: set API URL globally
d2fd5ea 
Change-Id: Ib4124ff3dc885e609bb51b96f263b4733d5bc143
@jd jd changed the base branch from devs/jd/capture-logs/If270ed8386e51ce7e9bc011fbe95a20f18aec323 to main December 18, 2024 16:31
@jd jd force-pushed the devs/jd/capture-logs/Ib4124ff3dc885e609bb51b96f263b4733d5bc143 branch from a9a8311 to d2fd5ea Compare December 18, 2024 16:31
@mergify mergify bot requested a review from a team December 18, 2024 16:32
@mergify mergify bot merged commit e71e7fe into main Dec 18, 2024
9 checks passed
@mergify mergify bot added the queued label Dec 18, 2024
@mergify mergify bot deleted the devs/jd/capture-logs/Ib4124ff3dc885e609bb51b96f263b4733d5bc143 branch December 18, 2024 16:47
@mergify mergify bot removed the queued label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Greesb Greesb Greesb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jd @Greesb