Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capture OpenTelemetry logs #26

Merged

Conversation

jd
Copy link
Member

@jd jd commented Dec 19, 2024

This makes sure that if error while uploading are triggered they are
reported at the end of the test session. This makes it easier to debug
issues.

@jd
Copy link
Member Author

jd commented Dec 19, 2024

This pull request is part of a stack:

  1. feat: capture OpenTelemetry logs (#26) 👈
  2. feat: print an error if repo name is not found (#27)

@mergify mergify bot requested a review from a team December 19, 2024 08:42
Copy link

mergify bot commented Dec 19, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • label = skip changelog
    • -title ~= ^feat
    • label = need changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

Base automatically changed from devs/jd/capture-logs/I2de0216fc8a6ef4cca1f37d00e56e97a2552f2b6 to main December 19, 2024 08:42
This makes sure that if error while uploading are triggered they are
reported at the end of the test session. This makes it easier to debug
issues.

Change-Id: I1dbd3e032e49ed916e2a02102dc68e706ea1cab5
@jd jd force-pushed the devs/jd/capture-logs/I1dbd3e032e49ed916e2a02102dc68e706ea1cab5 branch from 9499e66 to 5f593c9 Compare December 19, 2024 08:43
@mergify mergify bot merged commit b2c40ff into main Dec 19, 2024
14 checks passed
@mergify mergify bot added the queued label Dec 19, 2024
@mergify mergify bot deleted the devs/jd/capture-logs/I1dbd3e032e49ed916e2a02102dc68e706ea1cab5 branch December 19, 2024 09:10
@mergify mergify bot removed the queued label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants