Skip to content

GH-711: Review Two #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bertllll wants to merge 48 commits into
base: GH-711-review-one-saved-state
Choose a base branch
from
Open

GH-711: Review Two #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
dc4d63b
GH-711: first fixes from the review...finalizing 'Percentage'
Sep 13, 2024
ea7380e
GH-711: Pecentage looks done
Sep 13, 2024
d540732
GH-711: First handful of changes for verify_bill_payment
Sep 16, 2024
53da726
GH-711: verify_bill_payments significant improvement in arrangement
Sep 19, 2024
271e8f9
Merge branch 'GH-711-addressing-review-1' into GH-711-review-one
Sep 19, 2024
d4c15bd
GH-711-review-one: adding directives to ignore files
Sep 19, 2024
f192424
GH-711-review-one: more work done on verify_bill_payments; savepoint
Sep 21, 2024
baf51c4
GH-711-review-one: Decent version of verify_bill_payments
Sep 22, 2024
eedf9ce
GH-711-review-one: interim commit
Sep 22, 2024
a9f86ae
GH-711-review-one: the revamp of the verify_bill_payment is finishing…
Sep 25, 2024
9067c8c
GH-711-review-one: minor clean-up
Oct 2, 2024
6bb13e7
GH-711-review-one: tests in verify_bill_payments are in a fine condit…
Oct 2, 2024
788c1f5
GH-711-review-one: mid-scan space more ergonomical by code
Oct 5, 2024
bb207cd
GH-711-review-one: a few more comments kncoked off in Accountant
Oct 5, 2024
5cfc84f
GH-711-review-one: accountant/mod.rs finished
Oct 6, 2024
5561d3d
GH-711-review-one: more comments swept off after work done
Oct 6, 2024
5e397f4
GH-711-review-one: another chunk of repairs (logging fns, type conver…
Oct 24, 2024
719d701
GH-711-review-one: more repairs in data_structures, accounts_abstract…
bertllll Oct 25, 2024
bc15ac9
GH-711-review-one: interim commit
bertllll Oct 29, 2024
b73f96e
GH-711-review-one: helper functions repaired
bertllll Nov 4, 2024
a1f97de
GH-711-review-one: interim commit
bertllll Nov 4, 2024
2a36919
GH-711-review-one: big refactoring in the mod.rs file, also getting r…
bertllll Nov 4, 2024
e6c817c
GH-711-review-one: interim commit
bertllll Nov 5, 2024
bf272f5
GH-711-review-one: new fixes in the main mod
Nov 10, 2024
dc69d86
GH-711-review-one: interim commit
Nov 10, 2024
00e0cbe
GH-711-review-one: interim commit
Nov 14, 2024
7cec579
GH-711-review-one: interim commit
Dec 5, 2024
e99725b
GH-711-review-one: tests with more illustrative disqualification limi…
Dec 5, 2024
bfdcf97
GH-711-review-one: more tests repaired
Dec 6, 2024
490fe96
GH-711-review-one: mod.rs taken care of fully
Dec 7, 2024
5f038dd
GH-711-review-one: interim commit
Dec 7, 2024
2c8df5e
GH-711-review-one: more improvements
Dec 7, 2024
4c04716
GH-711-review-one: using much multipliers for more ergonomiv number w…
Dec 11, 2024
d30ccf0
GH-711-review-one: more little improvements; the fuzz test
Dec 11, 2024
bacf170
GH-711-review-one: refactoring in the fuzz test
Dec 12, 2024
4602f2d
GH-711-review-one: finished refactoring the fuzz test
Dec 13, 2024
f316cce
GH-711-review-one: interim commit
bertllll Dec 14, 2024
db2c222
GH-711: Now PA is immutable at outside
bertllll Dec 22, 2024
bd1e678
GH-711: Now PA is immutable at outside
bertllll Dec 22, 2024
969f423
GH-711: another wholesome fix for two tests
bertllll Dec 22, 2024
e789c81
GH-711: merged with remote branch (silly lil divergence)
bertllll Dec 22, 2024
2178e11
GH-711: a few more little fixes
bertllll Dec 23, 2024
200ea4f
GH-711: repaired panic messages
bertllll Dec 27, 2024
f19c889
GH-711: some harsh modification for older auxiliary test structures
bertllll Dec 28, 2024
fca8071
GH-711: this is almost the last batch out of the comments in the review
bertllll Dec 29, 2024
a75bfe3
GH-711: last case of repair before wallet -> address
bertllll Jan 2, 2025
9aa24b6
GH-711-review-one: everything in the review addressed
Jan 3, 2025
5b432d0
GH-711-review-one: after ci/all.sh
Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions automap/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
automap.log

## File-based project format:
*.iws
*.iml
*.ipr
5 changes: 5 additions & 0 deletions dns_utility/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
generated/

## File-based project format:
*.iws
*.iml
*.ipr
5 changes: 5 additions & 0 deletions masq/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

## File-based project format:
*.iws
*.iml
*.ipr
Loading